From: Paul Duncan <pabs@...>
Date: 2006-01-14T03:56:56+09:00
Subject: [PATCH] Additional RDoc HTML Cleanups (was "Re: [PATCH] Ruby 1.8.4 RDoc HTML Cleanups ...")

--tpyx7gKuSYt+mjHM
Content-Type: multipart/mixed; boundary="1rguoi8KZGYj2k4L"
Content-Disposition: inline


--1rguoi8KZGYj2k4L
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

* H.Yamamoto (ocean@m2.ccsnet.ne.jp) wrote:
[snipped]
> I recomend you to check html with W3C validater. Upload html and click
> [validate] link. Did you check that?=20

I'm aware of the W3C's HTML validator.  The HTML 4.0 specification
itself recommends that user agents ignore attributes they don't
understand.  From the spec itself:

  * If a user agent encounters an attribute it does not recognize, it
  should ignore the entire attribute specification (i.e., the attribute
  and its value).

  http://www.w3.org/TR/REC-html40/appendix/notes.html#notes-invalid-docs

Regardless, the second patch I submitted removed the attribute in
question, so this portion of the thread is irrelevant, and I won't be
responding to any more comments on it.

> And why do you want to change body's color?

#bbb and #BBBBBB are equivalent.  I moved the background color into the
stylesheet because it's cleaner, more concise, and more correct.

> Why don't you make all "CVS" to acnonym elements?=20
> And why was one font=3D-3 left unquoted?

The original HTML templates aren't mine.  Errors and omissions should be
directed to the original authors or the maintainer, not me.

That said, I've written a patch which fixes both of the issues you
mentioned above.  It's attached to this message, and also available
online here:

  http://diff.pablotron.org/ruby-1.8.4-rdoc_font_and_cvs_fix.diff

All of the RDoc changes from this thread, including the changes in the
patch above, are also available online as a separate, aggregate patch
against Ruby 1.8.4 at the following URL:

  http://diff.pablotron.org/ruby-1.8.4-rdoc_html_cleanups-3.diff

--=20
Paul Duncan <pabs@pablotron.org>        OpenPGP Key ID: 0x82C29562
http://www.pablotron.org/               http://www.paulduncan.org/

--1rguoi8KZGYj2k4L
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="ruby-1.8.4-rdoc_font_and_cvs_fix.diff"

diff -ur ruby-1.8.4-patched/lib/rdoc/generators/template/html/hefss.rb ruby-1.8.4/lib/rdoc/generators/template/html/hefss.rb
--- ruby-1.8.4-patched/lib/rdoc/generators/template/html/hefss.rb	2005-12-29 18:00:35.000000000 -0500
+++ ruby-1.8.4/lib/rdoc/generators/template/html/hefss.rb	2006-01-13 13:41:31.000000000 -0500
@@ -204,7 +204,7 @@
            <td  class="small-title-font">Path:</td>
            <td class="small-title-font">%full_path%
 IF:cvsurl
-				&nbsp;(<a href="%cvsurl%">CVS</a>)
+				&nbsp;(<a href="%cvsurl%"><acronym title="Concurrent Versioning System">CVS</acronym></a>)
 ENDIF:cvsurl
            </td>
          </tr>
diff -ur ruby-1.8.4-patched/lib/rdoc/generators/template/html/html.rb ruby-1.8.4/lib/rdoc/generators/template/html/html.rb
--- ruby-1.8.4-patched/lib/rdoc/generators/template/html/html.rb	2005-12-29 18:02:15.000000000 -0500
+++ ruby-1.8.4/lib/rdoc/generators/template/html/html.rb	2006-01-13 13:41:51.000000000 -0500
@@ -322,7 +322,7 @@
       <td><strong>Path:</strong></td>
       <td>%full_path%
 IF:cvsurl
-        &nbsp;(<a href="%cvsurl%">CVS</a>)
+        &nbsp;(<a href="%cvsurl%"><acronym title="Concurrent Versioning System">CVS</acronym></a>)
 ENDIF:cvsurl
       </td>
     </tr>
diff -ur ruby-1.8.4-patched/lib/rdoc/generators/template/html/kilmer.rb ruby-1.8.4/lib/rdoc/generators/template/html/kilmer.rb
--- ruby-1.8.4-patched/lib/rdoc/generators/template/html/kilmer.rb	2005-12-29 18:02:57.000000000 -0500
+++ ruby-1.8.4/lib/rdoc/generators/template/html/kilmer.rb	2006-01-13 13:42:49.000000000 -0500
@@ -192,7 +192,7 @@
 <table width="100%">
  <tr class="title-row">
  <td><table width="100%"><tr>
-   <td class="big-title-font" colspan='2'><font size=-3><b>File</b><br /></font>%short_name%</td>
+   <td class="big-title-font" colspan='2'><font size='-3'><b>File</b><br /></font>%short_name%</td>
    <td align="right"><table cellspacing="0" cellpadding="2">
          <tr>
            <td  class="small-title-font">Path:</td>
diff -ur ruby-1.8.4-patched/lib/rdoc/generators/template/html/old_html.rb ruby-1.8.4/lib/rdoc/generators/template/html/old_html.rb
--- ruby-1.8.4-patched/lib/rdoc/generators/template/html/old_html.rb	2006-01-13 10:56:59.000000000 -0500
+++ ruby-1.8.4/lib/rdoc/generators/template/html/old_html.rb	2006-01-13 13:42:29.000000000 -0500
@@ -497,7 +497,7 @@
            <td  class="small-title-font">Path:</td>
            <td class="small-title-font">%full_path%
 IF:cvsurl
-				&nbsp;(<a href="%cvsurl%">CVS</a>)
+				&nbsp;(<a href="%cvsurl%"><acronym title="Concurrent Versioning System">CVS</acronym></a>)
 ENDIF:cvsurl
            </td>
          </tr>
@@ -533,7 +533,7 @@
          </a>
 ENDIF:full_path_url
 IF:cvsurl
-         &nbsp;(<a href="%cvsurl%">CVS</a>)
+         &nbsp;(<a href="%cvsurl%"><acronym title="Concurrent Versioning System">CVS</acronym></a>)
 ENDIF:cvsurl
 <br />
 END:infiles

--1rguoi8KZGYj2k4L--

--tpyx7gKuSYt+mjHM
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)

iD8DBQFDx/frzdlT34LClWIRAgl8AJ9+cVEm2oBixqSpdgdqZ53+dNPSgwCgvPkI
uJ8FjQhxuAuO44Buh5mrZTQ=
=i3yv
-----END PGP SIGNATURE-----

--tpyx7gKuSYt+mjHM--