Re: Proposed patch to add SSL support to net/pop.rb

I agree that there are a lot of arguments to #start, but I think it is the 
best way.  I looked at https.rb and imap.rb and I think the way that imap.rb 
implements this is the best way for pop.  I felt that adding SSL this way was 
the least invasive and kept the ability to do things like this:

Net::POP3.start(args...,usessl=true) { |pop|
  do stuff
}

Since people can do this now (without SSL), I wanted to add the ability to 
have the same code but add SSL support.  I also don't think people should 
have to create ssl contexts to use ssl, that should all be hidden away.

On Monday 29 March 2004 11:05 pm, Minero Aoki wrote:
> Hi,
>
>   In mail "Re: Proposed patch to add SSL support to net/pop.rb"
>
>     Daniel Hobe <[e-mail]> wrote:
> > v3 of the patch:
> >
> > A few more cleanups.  I've tested this against the courier POP server but
> > not with APOP.
> >
> > -    #     Net::POP3.start(address, port, account, password) {|pop|
> > +    #     Net::POP3.start(address, port, account, password,
> > +    #                     isapop, usessl, certs, verify) {|pop|
>
> I think that #start has taken too many parameters.
> How do you think about adding POP3#use_ssl= method,
> such as Net::HTTPS?  For example,
>
>   pop = Net::POP.new(...)
>   pop.use_ssl = true
>   pop.ssl_context = ...
>   pop.start {
>     ....
>   }
>
> This code is little longer than yours, but the intention
> is more clear.
>
>
> Best Regards,
> Minero Aoki

-- 
Daniel Hobe <[e-mail]>
http://www.nightrunner.com