Re: problem with Net::HTTP in 1.8.1

Hi,

At Fri, 5 Mar 2004 08:53:38 +0900,
Ian Macdonald wrote in [ruby-core:02577]:
> The following code seems to cause an infinite loop:
> 
>   #!/usr/bin/ruby -w
>   
>   require 'net/http'
>   
>   http = Net::HTTP.start('www.google.com', 80)
>   
>   response = http.get('/')
>   puts response.header
> 
> 
> This causes the following bogus message to be printed indefinitely:
> 
> net/http.rb: warning: Net::HTTP v1.1 style assignment found at ./foo:8:in `puts'; use `response = http.get(...)' instead.

HTTPResponse#to_ary returns an array contains itself, and #puts
tries to traverse it and causes infinite recursion.

In the meantime, the following patch could get rid of the
problem.


Index: lib/net/http.rb
===================================================================
RCS file: /cvs/ruby/src/ruby/lib/net/http.rb,v
retrieving revision 1.105
diff -u -2 -p -d -r1.105 http.rb
--- lib/net/http.rb	8 Feb 2004 05:24:47 -0000	1.105
+++ lib/net/http.rb	5 Mar 2004 00:00:28 -0000
@@ -1608,5 +1608,9 @@ module Net # :nodoc:
     def to_ary
       warn "net/http.rb: warning: Net::HTTP v1.1 style assignment found at #{caller(1)[0]}; use `response = http.get(...)' instead." if $VERBOSE
-      [self, body()]
+      resp = self.dup
+      class << resp
+        undef to_ary
+      end
+      [resp, body()]
     end
 


-- 
Nobu Nakada