[ruby-core:24544] Re: [ruby-cvs:31226] Ruby:r24008 (ruby_1_8_6): Removed private on to_date and to_datetime.

On Tue, Jul 21, 2009 at 5:09 AM, Marcus Rueckert<[e-mail]> wrote:
> On 2009-07-21 18:14:59 +0900, Urabe Shyouhei wrote:
>> I've just been told by another Japanese rubyist that 1.8.6 added some ne=
w
>> public API. =A0I'm neutral to that, but honestly a bit surprised at it b=
ecause
>> AFAIK there was no discussion on this list about this change. =A0Can som=
eone show
>> me a pointer on such discussion if any?
>>
>> [e-mail] wrote:
>> > wyhaines =A0 =A02009-07-10 03:48:23 +0900 (Fri, 10 Jul 2009)
>> >
>> > =A0 New Revision: 24008
>> >
>> > =A0 http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=3Drev&revision=3D=
24008
>> >
>> > =A0 Log:
>> > =A0 =A0 Removed private on to_date and to_datetime.
>> >
>> > =A0 Modified files:
>> > =A0 =A0 branches/ruby_1_8_6/ChangeLog
>> > =A0 =A0 branches/ruby_1_8_6/lib/date.rb
>> > =A0 =A0 branches/ruby_1_8_6/version.h
>>
>
>
> I think he just applied my patch there. The thing is. Those methods had
> been in rails i think for quite a bit. then in some 1.8.6 patch release
> the methods suddenly got added as private methods in ruby core, with a
> sync from upstream of date2. that broke many rails applications.

This was solved in Rails in early 2007:
http://github.com/rails/rails/commit/593b1b837d24e61ea8f5386d66669585f3c14d=
5a

Those affected can upgrade Rails or hotfix their app using:
http://github.com/rails/rails/blob/0c68d23f19010379a9320690ca17a26743c8f071=
/activesupport/lib/active_support/core_ext/time/publicize_conversion_method=
s.rb

Best,
jeremy