From: Kirk Haines <wyhaines@...>
Date: 2009-07-22T22:10:37+09:00
Subject: [ruby-core:24503] Re: [ruby-cvs:31226] Ruby:r24008 (ruby_1_8_6): 	Removed private on to_date and to_datetime.

On Wed, Jul 22, 2009 at 2:55 AM, Urabe Shyouhei<shyouhei@ruby-lang.org> wrote:
> Kirk Haines wrote:
>> My apologies. When I was looking at that patch, I looked at trunk and
>> noted that the methods were not private in trunk, so I assumed it was
>> an OK patch. �I should have checked, as well, to see if it existed in
>> other 1.8.x versions.
>
> Don't mind. �There are days. �Then should we discuss whether or not to port
> to_date / to_datetime into 1.8 series? �As I wrote before, I'm neutral.

To be specific, in order to make sure we are all talking about the
same thing, to_date and to_datetime already exist in 1.8.  They were
added in r11005.  The change was to remove the private keyword on
Time#to_date and Time#to_datetime, as shown here:

http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/branches/ruby_1_8_6/lib/date.rb?r1=21864&r2=24008&pathrev=24008&sortby=rev&diff_format=h

The private keyword does not exist in trunk:

http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/trunk/lib/date.rb?view=markup&sortby=rev

This change seems reasonable for the 1.8 line to me.


Kirk Haines