[ruby-core:24474] Re: [ruby-cvs:31226] Ruby:r24008 (ruby_1_8_6): Removed private on to_date and to_datetime.

On 2009-07-21 18:14:59 +0900, Urabe Shyouhei wrote:
> I've just been told by another Japanese rubyist that 1.8.6 added some new
> public API.  I'm neutral to that, but honestly a bit surprised at it because
> AFAIK there was no discussion on this list about this change.  Can someone show
> me a pointer on such discussion if any?
> 
> [e-mail] wrote:
> > wyhaines	2009-07-10 03:48:23 +0900 (Fri, 10 Jul 2009)
> > 
> >   New Revision: 24008
> > 
> >   http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=24008
> > 
> >   Log:
> >     Removed private on to_date and to_datetime.
> > 
> >   Modified files:
> >     branches/ruby_1_8_6/ChangeLog
> >     branches/ruby_1_8_6/lib/date.rb
> >     branches/ruby_1_8_6/version.h
> 


I think he just applied my patch there. The thing is. Those methods had
been in rails i think for quite a bit. then in some 1.8.6 patch release
the methods suddenly got added as private methods in ruby core, with a
sync from upstream of date2. that broke many rails applications.

so as a package i just patched out the private statement.
so imho applying that fix upstream just fixes a breakage that got added
earlier. last but not least the methods are no longer private upstream
either.

hth

    darix

-- 
           openSUSE - SUSE Linux is my linux
               openSUSE is good for you
                   www.opensuse.org