[#11439] comments needed for Random class — "NAKAMURA, Hiroshi" <nakahiro@...>

-----BEGIN PGP SIGNED MESSAGE-----

15 messages 2007/06/12

[#11450] Re: new method dispatch rule (matz' proposal) — David Flanagan <david@...>

This is a late response to the very long thread that started back in

17 messages 2007/06/13

[#11482] Ruby Changes Its Mind About Non-Word Characters — James Edward Gray II <james@...>

Does this look like a bug to anyone else?

10 messages 2007/06/16

[#11505] Question about the patchlevel release cycle — Sylvain Joyeux <sylvain.joyeux@...4x.org>

1.8.6 thread support was broken in bad ways. It stayed for three months

20 messages 2007/06/20
[#11512] Re: Question about the patchlevel release cycle — Urabe Shyouhei <shyouhei@...> 2007/06/20

Hi, I'm the 1.8.6 branch manager.

[#11543] Re: Apple reportedly to ship with ruby 1.8.6-p36 unless informed what to patch — James Edward Gray II <james@...>

On Jun 27, 2007, at 4:47 PM, Bill Kelly wrote:

10 messages 2007/06/27

Unnecessary varargs for rb_hash_select

From: Daniel Berger <Daniel.Berger@...>
Date: 2007-06-22 15:00:19 UTC
List: ruby-core #11527
--- hash.orig   Fri Jun 22 08:42:30 2007
+++ hash.c      Fri Jun 22 08:43:12 2007
@@ -853,16 +853,11 @@
   */

  VALUE
-rb_hash_select(argc, argv, hash)
-    int argc;
-    VALUE *argv;
+rb_hash_select(hash)
      VALUE hash;
  {
      VALUE result;

-    if (argc > 0) {
-       rb_raise(rb_eArgError, "wrong number of arguments (%d for 0)", 
argc);
-    }
      result = rb_ary_new();
      rb_hash_foreach(hash, select_i, result);
      return result;
@@ -2499,7 +2494,7 @@
      rb_define_method(rb_cHash,"shift", rb_hash_shift, 0);
      rb_define_method(rb_cHash,"delete", rb_hash_delete, 1);
      rb_define_method(rb_cHash,"delete_if", rb_hash_delete_if, 0);
-    rb_define_method(rb_cHash,"select", rb_hash_select, -1);
+    rb_define_method(rb_cHash,"select", rb_hash_select, 0);
      rb_define_method(rb_cHash,"reject", rb_hash_reject, 0);
      rb_define_method(rb_cHash,"reject!", rb_hash_reject_bang, 0);
      rb_define_method(rb_cHash,"clear", rb_hash_clear, 0);

In This Thread

Prev Next