ruby-core

So, is it correct to assume that for language constructs that create built-in types like Range, Array, Hash etc that user-defined initialize methods are never called?

[#11549] Re: Proc initialize method not called under certain circumstances — "Berger, Daniel" <Daniel.Berger@...> 2007/06/28

> -----Original Message-----

[#11550] Re: Proc initialize method not called under certain circumstances — MenTaLguY <mental@...> 2007/06/28

On Fri, 29 Jun 2007 06:24:48 +0900, "John Lam (CLR)" <jflam@microsoft.com> wrote:

[#11553] Re: Proc initialize method not called under certain circumstances — "Marcel Molina Jr." <marcel@...> 2007/06/28

On Fri, Jun 29, 2007 at 06:54:49AM +0900, MenTaLguY wrote:

[#11554] Re: Proc initialize method not called under certain circumstances — murphy <murphy@...> 2007/06/28

> ... for language constructs that create

[#11560] Re: Proc initialize method not called under certain circumstances — Yukihiro Matsumoto <matz@...> 2007/06/29

Hi,

[#11548] NilClass, TrueClass, FalseClass special cased for singleton classes? — "John Lam (CLR)" <jflam@...>

If you do:

3 messages 2007/06/28

[#11557] Re: NilClass, TrueClass, FalseClass special cased for singleton classes? — Nobuyoshi Nakada <nobu@...> 2007/06/29

Hi,

[#11559] Re: NilClass, TrueClass, FalseClass special cased for singleton classes? — Joel VanderWerf <vjoel@...> 2007/06/29

John Lam (CLR) wrote:

[#11555] Name of Classes — =?ISO-8859-15?Q?Wolfgang_N=E1dasi-Donner?= <wonado@...>

Moin, moin!

2 messages 2007/06/28

[#11558] Re: Name of Classes — Nobuyoshi Nakada <nobu@...> 2007/06/29

Moin,

[#11556] delete_if with destructive methods in block — Florian Gross <florgro@...>

Hi,

3 messages 2007/06/29

[#11561] Re: [BUG] delete_if with destructive methods in block — Nobuyoshi Nakada <nobu@...> 2007/06/29

Hi,

[#11567] Re: delete_if with destructive methods in block — Florian Gross <florgro@...> 2007/06/30

That fixes it for me. I got no regressions from Rubinius' hash spec

[#11562] Can clear frozen array using initialize() — Florian Gross <florgro@...>

Hi,

2 messages 2007/06/29

[#11563] Re: [BUG] Can clear frozen array using initialize() — Yukihiro Matsumoto <matz@...> 2007/06/30

Hi,

[PATCH] URI::Generic: remove [] from IPv6 hosts

From: Stephan Maka <stephan@...>

Date: 2007-06-01 11:52:18 UTC

List: ruby-core #11385

Hi

When parsing an URI such as "http://[::1]/..." the host part will be
"[::1]".  This is not useful for ie. TCPSocket::new. The attached patch
removes the brackets when parsing and reattaches them at serialization.

I know the code has poor style but should explain what I mean.


Stephan

Attachments (1)

ruby-1.8.6-uri-ipv6.patch (1.94 KB, text/x-diff)

diff -urN ruby-1.8.6/lib/uri/common.rb ruby-1.8.6-mine/lib/uri/common.rb
--- ruby-1.8.6/lib/uri/common.rb	2007-02-15 03:41:45.000000000 +0100
+++ ruby-1.8.6-mine/lib/uri/common.rb	2007-06-01 13:30:58.000000000 +0200
@@ -184,6 +184,8 @@
 
     # :stopdoc:
 
+    IPV6REF = Regexp.new('^' + PATTERN::IPV6REF + '$')
+
     # for URI::split
     ABS_URI = Regexp.new('^' + PATTERN::X_ABS_URI + '$', #'
                          Regexp::EXTENDED, 'N').freeze
@@ -437,6 +439,11 @@
     end
 
     path = '' if !path && !opaque # (see RFC2396 Section 5.2)
+    if host =~ IPV6REF
+      host.sub!(/^\[/, '')
+      host.sub!(/\]$/, '')
+    end
+
     ret = [
       scheme, 
       userinfo, host, port,         # X
diff -urN ruby-1.8.6/lib/uri/generic.rb ruby-1.8.6-mine/lib/uri/generic.rb
--- ruby-1.8.6/lib/uri/generic.rb	2007-02-15 08:45:04.000000000 +0100
+++ ruby-1.8.6-mine/lib/uri/generic.rb	2007-06-01 13:30:35.000000000 +0200
@@ -1019,7 +1019,7 @@
             str << '@'
           end
           if @host
-            str << @host
+            str << ((@host =~ /:/) ? "[#{@host}]" : @host)
           end
           if @port && @port != self.default_port
             str << ':'
diff -urN ruby-1.8.6/test/uri/test_http.rb ruby-1.8.6-mine/test/uri/test_http.rb
--- ruby-1.8.6/test/uri/test_http.rb	2007-02-13 00:01:19.000000000 +0100
+++ ruby-1.8.6-mine/test/uri/test_http.rb	2007-06-01 13:35:18.000000000 +0200
@@ -57,6 +57,15 @@
       u.select(:scheme, :host, :not_exist, :port)
     end
   end
+
+  def test_ipv6
+    u1 = URI.parse('http://[fe80:1243:1234:1234:5678:5678:9abc:9abc]/')
+    assert_equal(['http', 'fe80:1243:1234:1234:5678:5678:9abc:9abc', 80, '/'], u1.select(:scheme, :host, :port, :path))
+    assert_equal('http://[fe80:1243:1234:1234:5678:5678:9abc:9abc]/', u1.to_s)
+    u2 = URI.parse('http://[::1]:8080/')
+    assert_equal(['http', '::1', 8080, '/'], u2.select(:scheme, :host, :port, :path))
+    assert_equal('http://[::1]:8080/', u2.to_s)
+  end
 end

Thread

Prev Next

In This Thread

Prev Next