[ruby-dev:29070] Re: irb completion

On Jul 18, 2006, at 8:15 AM, Yukihiro Matsumoto wrote:

> |これなんですが, irb/completion.rb の 1.10/1.8.2.2 
> (つまりRuby1.8と
> |Ruby1.9の最新版) で変わっているのですが, なん 
> で, こういう変更をするこ
> |とになったのでしょう? 変更の意図がわからないのです 
> が? というか, 限りな
> |く意味のない動作になっていると思うのですが... どこかで 
> こういう議論があっ
> |たのでしょうか?
>
> 1.10 の変更だと10日前ですか。
>
> Sun Jul  9 07:58:48 2006  Ryan Davis  <[e-mail]>
>
> 	* lib/irb/completion.rb: fixed a crasher when completing against
> 	  an unnamed class/module.
>
> という変更を許可した覚えがあります。要するに名前のないクラス
> とかだと落ちちゃうってことらしいです。

私の意思:

% cd ruby18
% cvs up -r1.8.2.1 lib/irb/completion.rb
% ./miniruby ./runruby.rb --extout=.ext -- ./bin/irb
irb(main):001:0> a=[]
=> []
irb(main):002:0> a.to_a.<TAB><TAB>
Display all 512 possibilities? (y or n) n
irb(main):003:0> def Date.name(explode);end
=> nil
irb(main):004:0> a.to_a./Users/ryan/Work/cvs/ruby-lang/ruby18/lib/irb/ 
completion.rb:141: [BUG] Bus Error
ruby 1.8.5 (2006-06-27) [i686-darwin8.7.1]

Abort trap
% cvs up -Ar ruby_1_8 lib/irb/completion.rb
P lib/irb/completion.rb
% ./miniruby ./runruby.rb --extout=.ext -- ./bin/irb
irb(main):001:0> require 'date'; def Date.name(explode);end; a=[]
=> []
irb(main):002:0> a.to_a.<TAB><TAB>
Display all 643 possibilities? (y or n) ^c

% cd ../ruby
% cvs up -r 1.9 lib/irb/completion.rb
% ./miniruby ./runruby.rb --extout=.ext -- ./bin/irb
irb(main):001:0> require 'date'; def Date.name(explode);end; a=[]
=> []
irb(main):002:0> a.to_a.<TAB><TAB>/Users/ryan/Work/cvs/ruby-lang/ruby/ 
lib/irb/completion.rb:141: [BUG] Bus Error
ruby 1.9.0 (2006-07-09) [i686-darwin8.7.1]

Abort trap
% cvs up -A lib/irb/completion.rb
P lib/irb/completion.rb
% ./miniruby ./runruby.rb --extout=.ext -- ./bin/irb
irb(main):001:0> require 'date'; def Date.name(explode);end; a=[]
=> []
irb(main):002:0> a.to_a.<TAB><TAB>/Users/ryan/Work/cvs/ruby-lang/ruby/ 
lib/irb/completion.rb:140: [BUG] Bus Error
ruby 1.9.0 (2006-07-09) [i686-darwin8.7.1]

Abort trap

DOH!

% cvs diff -du lib/irb/completion.rb
Index: lib/irb/completion.rb
===================================================================
RCS file: /src/ruby/lib/irb/completion.rb,v
retrieving revision 1.10
diff -d -u -r1.10 completion.rb
--- lib/irb/completion.rb       8 Jul 2006 23:17:50 -0000       1.10
+++ lib/irb/completion.rb       18 Jul 2006 18:22:16 -0000
@@ -137,8 +137,8 @@
         else
           # func1.func2
           candidates = []
-          name = m.name rescue ""
           ObjectSpace.each_object(Module){|m|
+            name = m.name rescue ""
             next if name != "IRB::Context" and
               /^(IRB|SLex|RubyLex|RubyToken)/ =~ name
             candidates.concat m.instance_methods(false)

% ./miniruby ./runruby.rb --extout=.ext -- ./bin/irb
irb(main):001:0> require 'date'; def Date.name(explode);end; a=[]
=> []
irb(main):002:0> a.to_a.<TAB><TAB>
Display all 585 possibilities? (y or n)

残念!!