From: Romulo Ceccon <redmine@...>
Date: 2010-05-17T00:00:46+09:00
Subject: [ruby-core:30268] [Bug #3299] revision.h rule in common.mk is broken for MSVC

Issue #3299 has been updated by Romulo Ceccon.


Sorry Nobuyoshi, but now (after commit r27799) ruby doesn't compile anymore:

          cl -nologo -MD   -O2b2xty-  -DRUBY_EXPORT -I. -I. -I./missing  -D_CRT_SECURE_NO_DEPRECATE -D_CRT_NONSTDC_NO_DEPRECATE    -c -Tcversion.c
  version.c
  version.c(45) : error C2229: struct '<unnamed-tag>' has an illegal zero-sized array
  NMAKE : fatal error U1077: '"C:\Arquivos de programas\Microsoft Visual Studio 9.0\VC\BIN\cl.EXE"' : return code '0x2'
  Stop.

Somehow the new rules are generating an empty revision.h. Also, the sed statement still has improperly escaped characters and fails on Windows (this was tested separately, not through the Makefile). I don't think it's possible to have the sed expressions escaped correctly for both Windows and Posix systems (due to different semantics of characteres ' and " in both platforms). That's why I proposed moving the expressions to a separate file.
----------------------------------------
http://redmine.ruby-lang.org/issues/show/3299

----------------------------------------
http://redmine.ruby-lang.org