From: Romulo Ceccon <redmine@...>
Date: 2010-05-15T05:36:05+09:00
Subject: [ruby-core:30249] [Bug #3299] revision.h rule in common.mk is broken for MSVC

Bug #3299: revision.h rule in common.mk is broken for MSVC
http://redmine.ruby-lang.org/issues/show/3299

Author: Romulo Ceccon
Status: Open, Priority: Normal
Category: build, Target version: Ruby 1.8.8
ruby -v: ruby 1.8.8dev [i386-mswin32_90]

Commit 27107 <http://redmine.ruby-lang.org/repositories/revision/ruby-18?rev=27107> broke revision.h rule when trying to compile with MSVC:

  '{' is not recognized as an internal or external command,
  operable program or batch file.
  NMAKE : warning U4004: too many rules for target './revision.h'
          cl -nologo -MD   -O2b2xty-  -DRUBY_EXPORT -I. -I. -I./missing  -D_CRT_SE
  CURE_NO_DEPRECATE -D_CRT_NONSTDC_NO_DEPRECATE    -c -Tcversion.c
  version.c

That doesn't stop compilation, but revision.h is left blank and no revision information is embedded in the executable.

Attached is a patch which fixes the problem with multiple rules and moves the sed expressions to a file so that the command runs correctly on both Windows and Posix systems (currently the sed statement will not work on Windows due to improperly escaped characters).


----------------------------------------
http://redmine.ruby-lang.org