[ruby-core:30227] Re: [Feature #3176] Thread#priority= should actually do something

On 5/13/10, Yusuke Endoh <[e-mail]> wrote:
> Issue #3176 has been updated by Yusuke Endoh.
>
> Assigned to set to Koichi Sasada
> Target version set to 1.9.x
>
> Hi, Caleb
>
> Great.  I glanced over your patch.  I think the biggest change is how
> thread waits GVL.  It is quite funny because ko1 recently does the
> same to fix another issue (thread starvation on many core environment).
> (The fix have not been committed yet.)
> I had concerned its performance cost, but if ko1 agrees with it, I
> also agree.

Results of performance experiments should be forthcoming in a day or
so, when I get a chance  to run them. Some preliminary and
unscientific tests have shown no appreciable slowdown.

> However, ko1 seems to still dislike the priority support for some
> reason.  I don't know the precise reason.  He said he would answer to
> this ticket, so please wait for him.

Well, if he has been touching the same areas, our patches are likely
to collide. I'll be happy to fix any conflicts or other problems that
arise. (Or at least try. I may not necessarily understand whatever it
is ko1 is doing.)

> Anyway, thank you for your writing a patch.

Thank you for reviewing it.

> One comment for the patch: not-static functions (like pqueue_*) should
> prefix "rb_" to avoid conflict with symbols of other projects, even if
> they are just for internal.

Ok, easy enough to change.