From: Jonan Scheffler <jonanscheffler@...>
Date: 2012-03-25T22:01:42+09:00
Subject: Re: Array handling trouble for new guy

--f46d043bde66c4b05904bc10dbf6
Content-Type: text/plain; charset=ISO-8859-1

OK so I just looked at this again and decided my answer isn't very helpful.

It looks like you're reassigning empty arrays every time your
first/middle/last_names methods are called.

Try this:

class Namer # Intending it to be a random name generator eventually

 def initialize ()
   @first_names = []
   @middle_names = []
   @last_names = []

   name_file = File.open('c:\ruby\data.txt')

   name_file.each_line do |name|
     @first_names.push(name.to_s) if name =~ /1/
     @middle_names.push(name.to_s) if name =~ /2/
     @last_names.push(name.to_s) if name =~ /3/
   end

   name_file.close
 end

 def print_names ()
   print "First Names"
   print @first_names

   print "Middle Names"
   print @middle_names

   print "Last Names"
   print @last_names
 end
end

working = Namer.new
working.print_names

On Sun, Mar 25, 2012 at 8:29 AM, Jonan Scheffler
<jonanscheffler@gmail.com>wrote:

> Your instance variables aren't being used consistently.
>
> Try taking your first_names method apart and pushing directly on to the
> instance variable.
>
> @first_names.push(name) if name =~ /1/
> On Mar 25, 2012 8:14 AM, "Aaron Brink" <lists@ruby-forum.com> wrote:
>
>> Greetings all,
>>
>> I'm dipping my toes into Ruby and have hit a stumbling block.  I'm
>> attempting to write a random name generator as an exercise for myself.
>> So far I've got it reading from a data file but can't seem to get it to
>> populate the arrays.  I'm sure I'm missing something as far as variable
>> scope goes but can't seem to dig it out of the documentation.  Each name
>> in the file has a number at the end to identify whether or not it's
>> first,
>> middle or last.  I figure I'll .chop the final array to get rid of the
>> extra character but haven't gotten that far.  Any help would be greatly
>> appreciated.
>>
>>
>>
>> class Namer # Intending it to be a random name generator eventually
>>
>>  def first_names
>>    @first_names=[]
>>  end
>>
>>  def middle_names
>>    @middle_names=[]
>>  end
>>
>>  def last_names
>>    @last_names=[]
>>  end
>>
>>  def initialize ()
>>    name_file = File.open('c:\ruby\data.txt')
>>    name_file.each_line do |name|
>>
>> # just a test to see if I was pulling in the data correctly, seems to
>> work
>>     print name.to_s
>>
>>
>> #  This is the section that I can't figure out.  Nothing gets pushed
>> into the arrays
>>     first_names.push(name.to_s) if name =~ /1/
>>     middle_names.push(name.to_s) if name =~ /2/
>>     last_names.push(name.to_s) if name =~ /3/
>>
>>    end
>>    name_file.close
>>  end
>>
>>  def print_names ()
>>    print "First Names"
>>    print first_names
>>
>>    print "Middle Names"
>>    print middle_names
>>
>>    print "Last Names"
>>    print last_names
>>  end
>> end
>>
>> working = Namer.new
>> working.print_names
>>
>> --
>> Posted via http://www.ruby-forum.com/.
>>
>>


-- 
Jonan Scheffler
jonanscheffler@gmail.com
(503) 985-6626

--f46d043bde66c4b05904bc10dbf6
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

OK so I just looked at this again and decided my answer isn&#39;t very help=
ful.=A0<div><br></div><div>It looks like you&#39;re reassigning empty array=
s every time your first/middle/last_names methods are called.</div><div><br=
>

</div><div>Try this:</div><div><br></div><div><div>class Namer # Intending =
it to be a random name generator eventually</div><div><br></div><div>=A0def=
 initialize ()</div><div>=A0 =A0@first_names =3D []</div><div>=A0 =A0@middl=
e_names =3D []</div>

<div>=A0 =A0@last_names =3D []</div><div><br></div><div>=A0 =A0name_file =
=3D File.open(&#39;c:\ruby\data.txt&#39;)</div><div><br></div><div>=A0 =A0n=
ame_file.each_line do |name|</div><div>=A0 =A0 =A0@first_names.push(name.to=
_s) if name =3D~ /1/</div>

<div>=A0 =A0 =A0@middle_names.push(name.to_s) if name =3D~ /2/</div><div>=
=A0 =A0 =A0@last_names.push(name.to_s) if name =3D~ /3/</div><div>=A0 =A0en=
d</div><div><br></div><div>=A0 =A0name_file.close</div><div>=A0end</div><di=
v><br></div><div>=A0def print_names ()</div>

<div>=A0 =A0print &quot;First Names&quot;</div><div>=A0 =A0print @first_nam=
es</div><div><br></div><div>=A0 =A0print &quot;Middle Names&quot;</div><div=
>=A0 =A0print @middle_names</div><div><br></div><div>=A0 =A0print &quot;Las=
t Names&quot;</div>

<div>=A0 =A0print @last_names</div><div>=A0end</div><div>end</div><div><br>=
</div><div>working =3D Namer.new</div><div>working.print_names</div></div><=
div><br></div><div><div><div class=3D"gmail_quote">On Sun, Mar 25, 2012 at =
8:29 AM, Jonan Scheffler <span dir=3D"ltr">&lt;<a href=3D"mailto:jonanschef=
fler@gmail.com">jonanscheffler@gmail.com</a>&gt;</span> wrote:<br>

<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex"><div class=3D"im"><p>Your instance variables=
 aren&#39;t being used consistently.</p>
<p>Try taking your first_names method apart and pushing directly on to the =
instance variable. </p>
<p>@first_names.push(name) if name =3D~ /1/</p>
</div><div class=3D"gmail_quote"><div class=3D"im">On Mar 25, 2012 8:14 AM,=
 &quot;Aaron Brink&quot; &lt;<a href=3D"mailto:lists@ruby-forum.com" target=
=3D"_blank">lists@ruby-forum.com</a>&gt; wrote:<br type=3D"attribution"></d=
iv><div>

<div class=3D"h5"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .=
8ex;border-left:1px #ccc solid;padding-left:1ex">
Greetings all,<br>
<br>
I&#39;m dipping my toes into Ruby and have hit a stumbling block. =A0I&#39;=
m<br>
attempting to write a random name generator as an exercise for myself.<br>
So far I&#39;ve got it reading from a data file but can&#39;t seem to get i=
t to<br>
populate the arrays. =A0I&#39;m sure I&#39;m missing something as far as va=
riable<br>
scope goes but can&#39;t seem to dig it out of the documentation. =A0Each n=
ame<br>
in the file has a number at the end to identify whether or not it&#39;s<br>
first,<br>
middle or last. =A0I figure I&#39;ll .chop the final array to get rid of th=
e<br>
extra character but haven&#39;t gotten that far. =A0Any help would be great=
ly<br>
appreciated.<br>
<br>
<br>
<br>
class Namer # Intending it to be a random name generator eventually<br>
<br>
 =A0def first_names<br>
 =A0 =A0@first_names=3D[]<br>
 =A0end<br>
<br>
 =A0def middle_names<br>
 =A0 =A0@middle_names=3D[]<br>
 =A0end<br>
<br>
 =A0def last_names<br>
 =A0 =A0@last_names=3D[]<br>
 =A0end<br>
<br>
 =A0def initialize ()<br>
 =A0 =A0name_file =3D File.open(&#39;c:\ruby\data.txt&#39;)<br>
 =A0 =A0name_file.each_line do |name|<br>
<br>
# just a test to see if I was pulling in the data correctly, seems to<br>
work<br>
 =A0 =A0 print name.to_s<br>
<br>
<br>
# =A0This is the section that I can&#39;t figure out. =A0Nothing gets pushe=
d<br>
into the arrays<br>
 =A0 =A0 first_names.push(name.to_s) if name =3D~ /1/<br>
 =A0 =A0 middle_names.push(name.to_s) if name =3D~ /2/<br>
 =A0 =A0 last_names.push(name.to_s) if name =3D~ /3/<br>
<br>
 =A0 =A0end<br>
 =A0 =A0name_file.close<br>
 =A0end<br>
<br>
 =A0def print_names ()<br>
 =A0 =A0print &quot;First Names&quot;<br>
 =A0 =A0print first_names<br>
<br>
 =A0 =A0print &quot;Middle Names&quot;<br>
 =A0 =A0print middle_names<br>
<br>
 =A0 =A0print &quot;Last Names&quot;<br>
 =A0 =A0print last_names<br>
 =A0end<br>
end<br>
<br>
working =3D Namer.new<br>
working.print_names<br>
<br>
--<br>
Posted via <a href=3D"http://www.ruby-forum.com/" target=3D"_blank">http://=
www.ruby-forum.com/</a>.<br>
<br>
</blockquote></div></div></div>
</blockquote></div><br><br clear=3D"all"><div><br></div>-- <br><div>Jonan S=
cheffler</div><div><a href=3D"mailto:jonanscheffler@gmail.com" target=3D"_b=
lank">jonanscheffler@gmail.com</a></div><div>(503) 985-6626</div><br>
</div></div>

--f46d043bde66c4b05904bc10dbf6--