Re: Parse error within Regexp

On Sun, Feb 12, 2006 at 01:34:55AM +0900, Yukihiro Matsumoto wrote:
> |user@host:~$ ruby -e '"".scan / ,/'
> |-e:1: parse error, unexpected ','
> |"".scan / ,/
> |           ^
> |-e:1: unterminated string meets end of file
> 
> |I suppose this is not the intended behaviour. What do you
> |think?
> 
> Ruby interpreted '"".scan / ,/' as
> 
>   ("".scan) / ,/
> 
> i.e. the first slash was considered as a division operator.  You need
> to tell Ruby that is a regular expression, by reforming the expression.

Would something like this make sense?

$  ./ruby19 -e '"".scan / ,/'
-e:1: syntax error, unexpected ','
"".scan / ,/
           ^
-e:1: unterminated regexp meets end of file
                  ========



Index: parse.y
===================================================================
RCS file: /src/ruby/parse.y,v
retrieving revision 1.429
diff -p -u -r1.429 parse.y
--- parse.y     7 Jan 2006 06:40:37 -0000       1.429
+++ parse.y     11 Feb 2006 23:28:09 -0000
@@ -5194,9 +5194,16 @@ parser_parse_string(struct parser_params
     }
     pushback(c);
     if (tokadd_string(func, term, paren, &quote->nd_nest) == -1) {
-       ruby_sourceline = nd_line(quote);
-       rb_compile_error(PARSER_ARG  "unterminated string meets end of file");
-       return tSTRING_END;
+       if (func & STR_FUNC_REGEXP) {
+           ruby_sourceline = nd_line(quote);
+           rb_compile_error(PARSER_ARG  "unterminated regexp meets end of file");
+           return tREGEXP_END;
+       }
+       else {
+           ruby_sourceline = nd_line(quote);
+           rb_compile_error(PARSER_ARG  "unterminated string meets end of file");
+           return tSTRING_END;
+       }
     }

     tokfix();


-- 
Mauricio Fernandez