From: "nobu (Nobuyoshi Nakada)" <nobu@...>
Date: 2013-08-30T23:32:22+09:00
Subject: [ruby-core:56883] [ruby-trunk - Bug #8837] net/telnet: strange	implementation


Issue #8837 has been updated by nobu (Nobuyoshi Nakada).


Seems that it should be:
             if pt = buf.rindex(/\r\z/no)
               buf, rest = buf[0 ... pt], buf[pt .. -1]
             end
or
             if buf.chomp!("\r")
               rest = "\r"
             end
to me.
----------------------------------------
Bug #8837: net/telnet: strange implementation
https://bugs.ruby-lang.org/issues/8837#change-41431

Author: paddor (Patrik Wenger)
Status: Open
Priority: Normal
Assignee: 
Category: 
Target version: 
ruby -v: ruby 2.0.0p247 (2013-06-27 revision 41674) [x86_64-darwin10.8.0]
Backport: 1.9.3: UNKNOWN, 2.0.0: UNKNOWN


=begin
Net::Telnet#waitfor has IMHO a very strange line. See https://github.com/ruby/ruby/blob/trunk/lib/net/telnet.rb#L586.

As far as I can tell, this line always results in setting (({rest = ""})) due to the regular expression above always matching at the end of (({buf})).

Also, since (({rest})) is set to an empty string right before that, I think this line can be removed.

What's your opinion?

=end


-- 
http://bugs.ruby-lang.org/