From: "naruse (Yui NARUSE)" <naruse@...>
Date: 2013-09-17T18:07:38+09:00
Subject: [ruby-core:57243] [ruby-trunk - Bug #8768][Assigned] [PATCH]	tempfile: undefine finalizer on unlink


Issue #8768 has been updated by naruse (Yui NARUSE).

Status changed from Open to Assigned
Assignee set to nobu (Nobuyoshi Nakada)

I know you are not the maintainer but could you review and commit this?
----------------------------------------
Bug #8768: [PATCH] tempfile: undefine finalizer on unlink
https://bugs.ruby-lang.org/issues/8768#change-41862

Author: normalperson (Eric Wong)
Status: Assigned
Priority: Normal
Assignee: nobu (Nobuyoshi Nakada)
Category: lib
Target version: current: 2.1.0
ruby -v: ruby 2.1.0dev (2013-08-10 trunk 42491) [x86_64-linux]
Backport: 1.9.3: UNKNOWN, 2.0.0: UNKNOWN


* lib/tempfile.rb (Tempfile#unlink): undefine finalizer
    
running the finalizer on an unlinked Tempfile leads to a confusing
"removing ...done" message when using --debug.  We can rely on
normal GC to close.  rb_io_fptr_finalize will take care of closing
the descriptor without the extra finalizer for Tempfile.


-- 
http://bugs.ruby-lang.org/