[ruby-core:64352] [ruby-trunk - Bug #8771] Start does not use proxy configuration form ENV variables

Issue #8771 has been updated by Jason Meller.


Yui NARUSE wrote:
> It causes that a client can set http_proxy on CGI environments.
> 
> see also akr's comment on https://bugs.ruby-lang.org/issues/6546

Yui can you take closer look at this bug? The patch seems to set the variable correctly to avoid the CGI issue as defined in https://bugs.ruby-lang.org/issues/6546. I believe this bug is valid and that the page makes the behavior between Net::HTTP.start('google.com').get('/') and Net::HTTP.new('google.com').get('/') consistent when dealing with a proxy set in an environment variable.

----------------------------------------
Bug #8771: Start does not use proxy configuration form ENV variables
https://bugs.ruby-lang.org/issues/8771#change-48329

* Author: Sam Taylor
* Status: Rejected
* Priority: Normal
* Assignee: Yui NARUSE
* Category: lib
* Target version: 2.1.0
* ruby -v: 2.1.0dev
* Backport: 1.9.3: UNKNOWN, 2.0.0: UNKNOWN
----------------------------------------
=begin
* Start a fake proxy in a separate window: (({nc -l 8089}))
* (({export http_proxy=http://localhost:8089}))
* (({irb -r net/http}))
* (({Net::HTTP.start('google.com').get('/')}))
* Note that the above http request was not proxied using the environment configuration
* (({Net::HTTP.new('google.com').get('/')})) exhibits the correct behaviour, the proxied HTTP request can be seen in the nc output
=end

---Files--------------------------------
378.patch (3.07 KB)


-- 
https://bugs.ruby-lang.org/