[ruby-core:64564] [ruby-trunk - Bug #10086] [Closed] [PATCH] Remove exponents calculation from mathn.rb

Issue #10086 has been updated by Nobuyoshi Nakada.

Status changed from Feedback to Closed
% Done changed from 0 to 100

Applied in changeset r47290.

----------
lib/mathn.rb: remove built-in methods

* lib/mathn.rb (Fixnum#**, Bignum#**, Float#**, Rational#**):
  remove as these are now built-in.  [ruby-core:63973] [Bug #10086]

----------------------------------------
Bug #10086: [PATCH] Remove exponents calculation from mathn.rb
https://bugs.ruby-lang.org/issues/10086#change-48491

* Author: gogo tanaka
* Status: Closed
* Priority: Normal
* Assignee: 
* Category: lib
* Target version: 
* ruby -v: 2.1.1p76
* Backport: 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
#English

When we override `:**`, we make it alias as `:power!` (mathn.rb:L73, L102)

Like this.

```
alias power! ** unless method_defined? :power!
```

If user have define `:power!`, this `:power!` is called unintentionally.(mathn.rb:L82, L111)

```
  def ** (other)
    if self < 0 && other.round != other
      Complex(self, 0.0) ** other
    else
      power!(other)
    end
  end
```


Now that we can do such a exponents calculation without `mathn`, we don't need exetend `:**` in mathn.

That's why I remove `:**` from mathn.rb

#日本語

mathn.rb で `:**` を上書きする際に元の `:**` を `:power!` としてaliasを貼っていますが、(mathn.rb:L73, L102)

```
alias power! ** unless method_defined? :power!
```
使用者が `#power!` を定義していた場合、

(mathn.rb:L82, L111)

```
  def ** (other)
    if self < 0 && other.round != other
      Complex(self, 0.0) ** other
    else
      power!(other)
    end
  end
```


の部分で意図せず利用者が定義した`:power!` が呼ばれ可能性があるため、

またそもそもこの種の冪乗演算は `mathn` を必要とせずとも現在は実現されているため、

:** を `mathn` から削除致しました.

---Files--------------------------------
Remove_Fixnum#power_from_mathn.patch (810 Bytes)
Remove_Bignum#power_from_mathn.patch (811 Bytes)
Remove_Float#power_from_mathn.patch (496 Bytes)
Remove_Rational#power_from_mathn.patch (2.08 KB)
Fix_comment_at_mathn.patch (430 Bytes)
improve_rdoc_mathn_l8.patch (478 Bytes)
improve_rdoc_mathn_l20.patch (301 Bytes)


-- 
https://bugs.ruby-lang.org/