From: Eric Wong <normalperson@...>
Date: 2014-08-13T06:35:25+00:00
Subject: [ruby-core:64345] Re: [REJECT] implement method entry allocator + bitmap marking

SASADA Koichi <ko1@atdot.net> wrote:
> (2014/08/13 4:48), Eric Wong wrote:
> >     /* TODO: marking `me' can be more sophisticated way */
> 
> I only consider about speed, not CoW frindlyness.
> 
> I agree bitmap marking is not worth.

Thanks for the response.  I will update the comment instead:

--- a/vm.c
+++ b/vm.c
@@ -2008,7 +2008,8 @@ rb_thread_mark(void *ptr)
 		    rb_gc_mark(RUBY_VM_NORMAL_ISEQ_P(iseq) ? iseq->self : (VALUE)iseq);
 		}
 		if (cfp->me) {
-		    /* TODO: marking `me' can be more sophisticated way */
+		    /* bitmap marking `me' does not seem worth the trouble:
+		     * [ruby-core:64340] [ruby-core:64341] */
 		    ((rb_method_entry_t *)cfp->me)->mark = 1;
 		    rb_mark_method_entry(cfp->me);
 		}