From: hsbt@... Date: 2016-08-17T05:28:35+00:00 Subject: [ruby-core:76946] [Ruby trunk Bug#8837][Rejected] net/telnet: strange implementation Issue #8837 has been updated by Hiroshi SHIBATA. Status changed from Open to Rejected Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN to 2.1: UNKNOWN net-telnet has been extracted https://github.com/ruby/net-telnet ---------------------------------------- Bug #8837: net/telnet: strange implementation https://bugs.ruby-lang.org/issues/8837#change-60175 * Author: Patrik Wenger * Status: Rejected * Priority: Normal * Assignee: * ruby -v: ruby 2.0.0p247 (2013-06-27 revision 41674) [x86_64-darwin10.8.0] * Backport: 2.1: UNKNOWN ---------------------------------------- =begin Net::Telnet#waitfor has IMHO a very strange line. See https://github.com/ruby/ruby/blob/trunk/lib/net/telnet.rb#L586. As far as I can tell, this line always results in setting (({rest = ""})) due to the regular expression above always matching at the end of (({buf})). Also, since (({rest})) is set to an empty string right before that, I think this line can be removed. What's your opinion? =end -- https://bugs.ruby-lang.org/ Unsubscribe: