From: Avdi Grimm <avdi@...>
Date: 2013-08-14T17:56:50-04:00
Subject: [ruby-core:56623] Re: [ruby-trunk - Feature #8639] Add Queue#each

--001a11336bba8703fd04e3ef7022
Content-Type: text/plain; charset=ISO-8859-1

Thanks! I'm off to a conf this week, it probably would have been a awhile
before I got around to it.


On Wed, Aug 14, 2013 at 5:00 PM, zzak (Zachary Scott) <e@zzak.io> wrote:

>
> Issue #8639 has been updated by zzak (Zachary Scott).
>
> File 361.patch added
>
> Attaching the patch from Avdi's pull request on github, thank you!
> ----------------------------------------
> Feature #8639: Add Queue#each
> https://bugs.ruby-lang.org/issues/8639#change-41160
>
> Author: avdi (Avdi Grimm)
> Status: Open
> Priority: Normal
> Assignee: ko1 (Koichi Sasada)
> Category:
> Target version:
>
>
> I was fiddling around with Queue the other day and realized it doesn't
> have an #each method. So I made one: https://github.com/ruby/ruby/pull/361
>
> As for why, it makes for a convenient way to build consumer processes:
>
>   inq = Queue.new
>   outq = Queue.new
>   doubler = Thread.new do
>     inq.each do |n|
>       outq << n + n
>     end
>   end
>
> My PR also returns an Enumerator when no block is given, and handles the
> non_block argument.
>
> I'm sure there's some good reason that this method wasn't there already,
> so feel free to explain.
>
> Also, this is my first Ruby feature ticket so please let me know if I'm
> missing any points of protocol.
>
> Thanks!
>
>
> --
> http://bugs.ruby-lang.org/
>



-- 
Avdi Grimm
http://avdi.org

I only check email twice a day. to reach me sooner, go to
http://awayfind.com/avdi

--001a11336bba8703fd04e3ef7022
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Thanks! I&#39;m off to a conf this week, it probably would=
 have been a awhile before I got around to it.</div><div class=3D"gmail_ext=
ra"><br><br><div class=3D"gmail_quote">On Wed, Aug 14, 2013 at 5:00 PM, zza=
k (Zachary Scott) <span dir=3D"ltr">&lt;<a href=3D"mailto:e@zzak.io" target=
=3D"_blank">e@zzak.io</a>&gt;</span> wrote:<br>

<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex"><br>
Issue #8639 has been updated by zzak (Zachary Scott).<br>
<br>
File 361.patch added<br>
<br>
Attaching the patch from Avdi&#39;s pull request on github, thank you!<br>
<div class=3D"im">----------------------------------------<br>
Feature #8639: Add Queue#each<br>
</div><a href=3D"https://bugs.ruby-lang.org/issues/8639#change-41160" targe=
t=3D"_blank">https://bugs.ruby-lang.org/issues/8639#change-41160</a><br>
<div class=3D"im"><br>
Author: avdi (Avdi Grimm)<br>
Status: Open<br>
Priority: Normal<br>
</div>Assignee: ko1 (Koichi Sasada)<br>
<div class=3D"HOEnZb"><div class=3D"h5">Category:<br>
Target version:<br>
<br>
<br>
I was fiddling around with Queue the other day and realized it doesn&#39;t =
have an #each method. So I made one: <a href=3D"https://github.com/ruby/rub=
y/pull/361" target=3D"_blank">https://github.com/ruby/ruby/pull/361</a><br>


<br>
As for why, it makes for a convenient way to build consumer processes:<br>
<br>
=A0 inq =3D Queue.new<br>
=A0 outq =3D Queue.new<br>
=A0 doubler =3D Thread.new do<br>
=A0 =A0 inq.each do |n|<br>
=A0 =A0 =A0 outq &lt;&lt; n + n<br>
=A0 =A0 end<br>
=A0 end<br>
<br>
My PR also returns an Enumerator when no block is given, and handles the no=
n_block argument.<br>
<br>
I&#39;m sure there&#39;s some good reason that this method wasn&#39;t there=
 already, so feel free to explain.<br>
<br>
Also, this is my first Ruby feature ticket so please let me know if I&#39;m=
 missing any points of protocol.<br>
<br>
Thanks!<br>
<br>
<br>
--<br>
<a href=3D"http://bugs.ruby-lang.org/" target=3D"_blank">http://bugs.ruby-l=
ang.org/</a><br>
</div></div></blockquote></div><br><br clear=3D"all"><div><br></div>-- <br>=
Avdi Grimm<br><a href=3D"http://avdi.org" target=3D"_blank">http://avdi.org=
</a><br><br>I only check email twice a day. to reach me sooner, go to <a hr=
ef=3D"http://awayfind.com/avdi" target=3D"_blank">http://awayfind.com/avdi<=
/a>
</div>

--001a11336bba8703fd04e3ef7022--