Re: range.c

Hi,

In message "Re: range.c"
    on Sun, 31 Oct 2004 01:43:33 +0900, "trans.  (T. Onoma)" <[e-mail]> writes:

|range_hash(range)
|    VALUE range;
|{
|    long hash = EXCL(range);
|    VALUE v;
|
|    v = rb_hash(rb_ivar_get(range, id_beg));
|    hash ^= v << 1;
|    v = rb_hash(rb_ivar_get(range, id_end));
|    hash ^= v << 9;
|    hash ^= EXCL(range) << 24;
|    hash ^= EXCLB(range) << 25;   /* 25? what number? */
|
|    return LONG2FIX(hash);
|}

Hmm, I don't know why EXCL() is summed up twice.  How about

  hash = EXCL(range);
  hash |= EXCLB(range) << 1
  v = rb_hash(rb_ivar_get(range, id_beg));
  hash |= v << 2
  v = rb_hash(rb_ivar_get(range, id_end));
  hash ^= v << 10;

?

|Also, I am using 1.8.2pre2 code, should I be using 1.9?

Use 1.9 for major behavior change.

I don't think of no pragmatic usage of exclude_start except for
theoretical symmetry, so that it is relatively hard to persuade me to
merge it.  But that's another story.

							matz.