ruby-core

Patches item #1909, was opened at 2005-05-13 11:19
You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=1700&aid=1909&group_id=426

Category: Ruby1.8
>Group: v1.8.x
Status: Open
Resolution: None
Priority: 3
Submitted By: Daniel Berger (djberg96)
Assigned to: Nobody (None)
Summary: -Wall -W patch: bignum.c

Initial Comment:
--- bignum.orig Fri May 13 11:50:21 2005
+++ bignum.c    Fri May 13 11:56:54 2005
@@ -101,7 +101,7 @@
     VALUE x;
 {
     if (!FIXNUM_P(x)) {
-       long len = RBIGNUM(x)->len;
+       unsigned long len = RBIGNUM(x)->len;
        BDIGIT *ds = BDIGITS(x);
 
        while (len-- && !ds[len]) ;
@@ -135,7 +135,7 @@
     unsigned long n;
 {
     BDIGIT_DBL num = n;
-    long i = 0;
+    unsigned long i = 0;
     BDIGIT *digits;
     VALUE big;
 
@@ -223,7 +223,7 @@
 {
     unsigned LONG_LONG q;
     long neg = 0;
-    long i;
+    unsigned long i;
     BDIGIT *digits;
     VALUE big;
 
@@ -324,8 +324,7 @@
     char sign = 1, nondigit = 0;
     int c;
     BDIGIT_DBL num;
-    long len, blen = 1;
-    long i;
+    unsigned long i, len, blen = 1;
     VALUE z;
     BDIGIT *zds;
 
@@ -455,7 +454,7 @@
     z = bignew(len, sign);
     zds = BDIGITS(z);
     for (i=len;i--;) zds[i]=0;
-    while (c = *str++) {
+    while ((c = *str++)) {
        if (c == '_') {
            if (badcheck) {
                if (nondigit) goto bad;
@@ -544,7 +543,7 @@
     unsigned LONG_LONG n;
 {
     BDIGIT_DBL num = n;
-    long i = 0;
+    unsigned long i = 0;
     BDIGIT *digits;
     VALUE big;

Everything is still good:

>ruby test_bignum.rb 
Loaded suite test_bignum
Started
...
Finished in 0.505683 seconds.

3 tests, 164 assertions, 0 failures, 0 errors

----------------------------------------------------------------------

Comment By: Tom Copeland (tom)
Date: 2006-04-26 17:57

Message:
Testing to ensure comments still work for logged in users...

----------------------------------------------------------------------

Comment By: Tom Copeland (tom)
Date: 2006-04-26 17:55

Message:
Crikey, there was another bug - Artifact.addMessage() wasn't checking for allowAnon().  Bleah!  

Ok, let's see how this works now...

tom

----------------------------------------------------------------------

Comment By: Tom Copeland (tom)
Date: 2006-04-26 12:39

Message:
Hm.  Spam is still appearing... odd.  Must be something else.  I'm monitoring this patch now and will keep cleaning it up until I can figure out what's up.

Tom

----------------------------------------------------------------------

Comment By: Tom Copeland (tom)
Date: 2006-04-26 06:34

Message:
Done.  No more 'enter an email address' workaround.  Spammers begone!

tom

----------------------------------------------------------------------

Comment By: Tom Copeland (tom)
Date: 2006-04-26 06:31

Message:
Hm, looks like spammers have figured out the "enter an email address" thing, removing that now...

tom

----------------------------------------------------------------------

Comment By: Nobody (None)
Date: 2006-04-24 10:55

Message:
test

----------------------------------------------------------------------

You can respond by visiting: 
http://rubyforge.org/tracker/?func=detail&atid=1700&aid=1909&group_id=426

Thread

Prev Next

In This Thread

Prev Next

[#11066] question about frame_unique — Paul Brannan <pbrannan@...>

[#11069] High-precision Rationals cannot be converted to Floats — <noreply@...>

[#11070] Re: Welcome to our (ruby-core ML) You are added automatically — "Bunno Lim" <bunno_lim@...>

[#11071] autorunner -n option does not work in trunk — <noreply@...>

[#11073] segfault printing instruction sequence for iterator — <noreply@...>

[#11074] sub! causing unexpected side effect — <noreply@...>

[#11075] Ruby fails to parse valid wsdl — <noreply@...>

[#11076] Windows DEP causes crash — <noreply@...>

[#11077] Submitting an RDoc patch — gga <ggarra@...>

[#11078] sub! causing unexpected side effect — <noreply@...>

[#11079] ruby packer prototype: core dumps ( design review request ) — "Adam Bozanich" <adam.boz@...>

[#11081] sub! causing unexpected side effect — <noreply@...>

[#11082] Understanding code: Kernel#require and blocks. — Hugh Sasse <hgs@...>

[#11088] Net::HTTP encodes parameters improperly. — <noreply@...>

[#11090] parsedate fails — <noreply@...>

[#11092] return from block inside a lambda does not work as expected — <noreply@...>

[#11094] RDoc for Kernel#select same as IO.select — <noreply@...>

[#11095] RDoc for Kernel#select same as IO.select — <noreply@...>

[#11097] TestReadline fails depending on the terminal in which the test is run. — <noreply@...>

[#11098] Short read with readline, popen and timeout - first byte of the line disappears — <noreply@...>

[#11099] Short read with readline, popen and timeout - first byte of the line disappears — <noreply@...>

[#11100] Short read with readline, popen and timeout - first byte of the line disappears — <noreply@...>

[#11102] Net::HTTP encodes parameters improperly. — <noreply@...>

[#11103] irb attempts to escape '\c' inside single quotes — <noreply@...>

[#11104] overriding autoloads with classes and modules — Thomas Enebo <Thomas.Enebo@...>

[#11106] Failure parsing dates returned by WIN32OLE — <noreply@...>

[#11107] unable to build ruby HEAD without previously installed ruby — <noreply@...>

[#11108] pattern for implementation-private constants? — David Flanagan <david@...>

[#11117] BUGS in metaclasses inheritance — <noreply@...>

[#11118] BUGS in metaclasses inheritance — <noreply@...>

[#11121] Weird rounding behavior.. — <noreply@...>

[#11124] IRHG - Found interesting Japanese Document exploring various GC's — Charles Thornton <ceo@...>

[#11125] two fixes for sync.rb: sync_try_lock, Err.Fail — "Dmitry Borodaenko" <angdraug@...>

[#11127] Bugs that can be closed — "Jano Svitok" <jan.svitok@...>

[#11128] Weird rounding behavior.. — <noreply@...>

[#11129] sub! causing unexpected side effect — <noreply@...>

[#11130] :!~ not a symbol — <noreply@...>

[#11131] Documentation for String.scan has a bad example. — <noreply@...>

[#11132] rdoc/usage uses an uninitalized constant — <noreply@...>

[#11133] bug in newton.rb — <noreply@...>

[#11134] each_with_index (Enumerable) does not forward arguments to each — <noreply@...>

[#11135] Ruby Gem installer not playing nice on Ubuntu — <noreply@...>

[#11136] Ruby one-click installer wiped out system PATH environment variable. — <noreply@...>

[#11137] Ruby one-click installer wiped out system PATH environment variable. — <noreply@...>

[#11138] Marshal.dump shouldn't complain about singletons if the _dump method is defined — <noreply@...>

[#11139] exit from within block returns wrong value. — <noreply@...>

[#11140] :!~ not a symbol — <noreply@...>

[#11141] Weird rounding behavior.. — <noreply@...>

[#11143] Logger::Application accessor for logger — Brian Candler <B.Candler@...>

[#11144] Rational comparison to 0 fails when denominator is != 1 — <noreply@...>

[#11145] Rational comparison to 0 fails when denominator is != 1 — <noreply@...>

[#11147] RDoc patch to better support documenting multiple classes/SWIG — <noreply@...>

[#11150] "password" is case sensitive in lib/telnet.rb — <noreply@...>

[#11153] segfault printing instruction sequence for iterator — <noreply@...>

[#11154] Rational comparison to 0 fails when denominator is != 1 — <noreply@...>

[#11155] Class#=== bug — <noreply@...>

[#11156] Class#=== bug — <noreply@...>

[#11157] Class#=== bug — <noreply@...>

[#11158] Class#=== bug — <noreply@...>

[#11159] Rational comparison to 0 fails when denominator is != 1 — <noreply@...>

[#11165] Rational comparison to 0 fails when denominator is != 1 — <noreply@...>

[#11166] rdoc patches — Joel VanderWerf <vjoel@...>

[#11167] Date parsing bug with patch — <noreply@...>

[#11169] Allow back reference with nest level in Oniguruma for Ruby again — =?ISO-8859-15?Q?Wolfgang_N=E1dasi-Donner?= <wonado@...>

[#11171] Loss of precision during iteration. — <noreply@...>

[#11172] "read_nonblock" Problem (Windows and Ruby 1.8) — =?ISO-8859-15?Q?Wolfgang_N=E1dasi-Donner?= <wonado@...>

[#11174] Loss of precision during iteration. — <noreply@...>

[#11175] Loss of precision during iteration. — <noreply@...>

[#11176] FileUtils.rm_rf misfeature? — johan556@...

[#11177] Loss of precision during iteration. — <noreply@...>

[#11187] Garbage collection of Symbols in future release? — Sven Suska <sven716rc@...>

[#11193] IRHG -- Downloadable Files — Charles Thornton <ceo@...>

[#11204] URI Methods Raise Unclear Exceptions When Passed URI Objects — <noreply@...>

[#11206] ri HTML output bug with constants — Chris Thomas <chris@...>

[#11208] How to handle Change Proposals that affect mainly Oniguruma (for Ruby)? — =?ISO-8859-15?Q?Wolfgang_N=E1dasi-Donner?= <wonado@...>

[#11209] eval("0.0025 + 9 * 0.0025") === 0.025 => false — <noreply@...>

[#11210] Pathname ascend and descend inclusive parameter — TRANS <transfire@...>

[#11211] eval("0.0025 + 9 * 0.0025") === 0.025 => false — <noreply@...>

[#11213] eval(&quot;0.0025 + 9 * 0.0025&quot;) === 0.025 =&gt; false — <noreply@...>

[#11214] eval(&quot;0.0025 + 9 * 0.0025&quot;) === 0.025 =&gt; false — <noreply@...>

[#11213] eval("0.0025 + 9 * 0.0025") === 0.025 => false — <noreply@...>

[#11214] eval("0.0025 + 9 * 0.0025") === 0.025 => false — <noreply@...>

[#11216] eval("0.0025 + 9 * 0.0025") === 0.025 => false — <noreply@...>

[#11290] [TINY][PATCH] Array#last is not working for n > 3 — <noreply@...>

[#11291] In a c++ program, when I call "fclose()", or "ofstream::close()" in a file that includes ruby.h, the program crashes — <noreply@...>

[#11318] Problem with Benchmark::Tms#add! - expects &blk but takes no parameters — <noreply@...>