[#61424] [REJECT?] xmalloc/xfree: reduce atomic ops w/ thread-locals — Eric Wong <normalperson@...>

I'm unsure about this. I _hate_ the extra branches this adds;

13 messages 2014/03/12

[ruby-core:61637] [ruby-trunk - Bug #8177] ext/openssl/pkcs7 signing fails with EC keys

From: davispuh@...
Date: 2014-03-22 15:46:41 UTC
List: ruby-core #61637
Issue #8177 has been updated by Dト」is Mosト]s.


I'm still encountering similar issue with ruby 2.1.1p76 when using `OpenSSL::PKey::EC#sign`. Will it be fixed only in 2.2?

Using the following monkey-patch it does work.

~~~
class OpenSSL::PKey::EC
  def private?
    private_key?
  end
end
~~~

----------------------------------------
Bug #8177: ext/openssl/pkcs7 signing fails with EC keys
https://bugs.ruby-lang.org/issues/8177#change-45902

* Author: Joseph Coyle
* Status: Assigned
* Priority: Normal
* Assignee: Martin Bosslet
* Category: ext
* Target version: current: 2.2.0
* ruby -v: ruby 2.1.0dev (2013-03-27 trunk 39950) [x86_64-darwin11.4.2]
* Backport: 
----------------------------------------
ext/openssl/pkcs7 signing fails with EC keys.   This happens because the EC keys do not respond to key.private? method which is used to check that the key is a private key.  Aliasing the instance method OpenSSL::PKey::EC.private_key? as OpenSSL::PKey::EC.private? fixes this problem and allows EC keys to be used for EC key signing.

This problem is demonstrated at https://gist.github.com/Jacob640/5239454

One potential fix which makes the key interface more consistent is here: https://github.com/ruby/ruby/pull/265

This request also improves the EC public key interface by producing a warning if the public key is set before setting an EC group as required.

---Files--------------------------------
265.patch (1.87 KB)


-- 
https://bugs.ruby-lang.org/

In This Thread