From: ko1@... Date: 2014-03-07T11:10:30+00:00 Subject: [ruby-core:61369] [ruby-trunk - Bug #9609] [PATCH] vm_eval.c: fix misplaced RB_GC_GUARDs Issue #9609 has been updated by Koichi Sasada. (2014/03/07 20:03), SASADA Koichi wrote: >> > Should we ignore WB unprotect for frozen objects? > No relation between frozen and wb unprotected flag. We can use > RARRAY_CONST_PTR() for this case. I'll commit it with other patches. Ah, I understand what you mean. As you say, we *can* ignore unprotect. But I think the checking cost is bigger. -- // SASADA Koichi at atdot dot net ---------------------------------------- Bug #9609: [PATCH] vm_eval.c: fix misplaced RB_GC_GUARDs https://bugs.ruby-lang.org/issues/9609#change-45682 * Author: Eric Wong * Status: Open * Priority: Normal * Assignee: Eric Wong * Category: core * Target version: * ruby -v: - * Backport: 1.9.3: REQUIRED, 2.0.0: REQUIRED, 2.1: REQUIRED ---------------------------------------- RB_GC_GUARD needs to be placed after RARRAY_PTR usages to portably prevent compilers from optimizing the VALUE away. ---Files-------------------------------- 0001-vm_eval.c-fix-misplaced-GC-guard.patch (1.46 KB) -- http://bugs.ruby-lang.org/