[#61424] [REJECT?] xmalloc/xfree: reduce atomic ops w/ thread-locals — Eric Wong <normalperson@...>

I'm unsure about this. I _hate_ the extra branches this adds;

13 messages 2014/03/12

[ruby-core:61363] [ruby-trunk - Bug #9609] [PATCH] vm_eval.c: fix misplaced RB_GC_GUARDs

From: normalperson@...
Date: 2014-03-07 10:41:06 UTC
List: ruby-core #61363
Issue #9609 has been updated by Eric Wong.


 SASADA Koichi <ko1@atdot.net> wrote:
 > And also it should be RARRAY_CONST_PTR().
 
 Thanks (r45283).   Btw, I noticed rb_apply uses RARRAY_PTR, too,
 but also with OBJ_FREEZE.
 
 Should we ignore WB unprotect for frozen objects?

----------------------------------------
Bug #9609: [PATCH] vm_eval.c: fix misplaced RB_GC_GUARDs
https://bugs.ruby-lang.org/issues/9609#change-45679

* Author: Eric Wong
* Status: Open
* Priority: Normal
* Assignee: Eric Wong
* Category: core
* Target version: 
* ruby -v: -
* Backport: 1.9.3: REQUIRED, 2.0.0: REQUIRED, 2.1: REQUIRED
----------------------------------------
RB_GC_GUARD needs to be placed after RARRAY_PTR usages to portably
prevent compilers from optimizing the VALUE away.


---Files--------------------------------
0001-vm_eval.c-fix-misplaced-GC-guard.patch (1.46 KB)


-- 
http://bugs.ruby-lang.org/

In This Thread

Prev Next