[#61424] [REJECT?] xmalloc/xfree: reduce atomic ops w/ thread-locals — Eric Wong <normalperson@...>

I'm unsure about this. I _hate_ the extra branches this adds;

13 messages 2014/03/12

[ruby-core:61168] [Backport21 - Backport #9576] [Closed] Backport r44370 to revert Hash#reject behavior

From: naruse@...
Date: 2014-03-01 09:02:56 UTC
List: ruby-core #61168
Issue #9576 has been updated by Yui NARUSE.

Status changed from Open to Closed
% Done changed from 0 to 100

Applied in changeset r45227.

----------
merge revision(s) 44370: [Backport #9576]

	hash.c: extra states

	* hash.c (rb_hash_reject): use words "extra states".

----------------------------------------
Backport #9576: Backport r44370 to revert Hash#reject behavior
https://bugs.ruby-lang.org/issues/9576#change-45533

* Author: Shota Fukumori
* Status: Closed
* Priority: Normal
* Assignee: Yui NARUSE
----------------------------------------
In [Bug #9223], naruse-san rejected incompatible change due to HashWithIndifferentAccess.

r44358 had changed constant name, but there was one `ifdef` condition still use old constant name.
r44370 fixes it to correct one, but it's not backported to 2.1.1.

So HashWithIndifferentAccess in Ruby 2.1.1 is broken because Ruby 2.1.1's Hash#reject doesn't copy extra states.

- Commits around this change: https://gist.github.com/sorah/9265008
- Rails' issue: https://github.com/rails/rails/issues/14188



-- 
http://bugs.ruby-lang.org/

In This Thread

Prev Next