[#61424] [REJECT?] xmalloc/xfree: reduce atomic ops w/ thread-locals — Eric Wong <normalperson@...>

I'm unsure about this. I _hate_ the extra branches this adds;

13 messages 2014/03/12

[ruby-core:61223] Re: [ruby-trunk - Feature #9508] Add method coverage and branch coverage metrics

From: Eric Wong <normalperson@...>
Date: 2014-03-02 09:14:13 UTC
List: ruby-core #61223
sam.rawlins@gmail.com wrote:
> Oh, sorry, Eric. eaadf820633e74350404d009a1c251f6319454aa was just the last commit I made to tweak when coverage is initialized. The entire patch would be my cumulative pull request:
> 
> https://github.com/ruby/ruby/pull/511.patch

Yes, and your patch results in tree 7a51f93796a28bcbf9cb8fa25c6b752202c517ae
(which is your commit eaadf820633e74350404d009a1c251f6319454aa)

I also tried applying your series on top of current trunk, and got the
same result.

> I can compile ruby and run all coverage tests:

"make check" passed for me, too; but did you try my failing command?
  ruby -rcoverage -e 'Coverage.start; require "tempfile"'

In This Thread

Prev Next