[#61424] [REJECT?] xmalloc/xfree: reduce atomic ops w/ thread-locals — Eric Wong <normalperson@...>

I'm unsure about this. I _hate_ the extra branches this adds;

13 messages 2014/03/12

[ruby-core:61410] [ruby-trunk - Bug #9618] Pathname#cleanpath creates mixed path separators

From: daniel@...
Date: 2014-03-11 11:07:05 UTC
List: ruby-core #61410
Issue #9618 has been updated by Daniel Rikowski.


I'm not sure if converting the separators in `#initialize` is the best way to go. I can see the advantages, but I can also imagine existing programs breaking because of that.

Personally I'd prefer a more conservative approach which would remove ALT_SEPARATOR in `#cleanpath` only.

That way `#initialize` would gain a new (minor) feature as opposed to `Pathname` losing a (major) feature. (i.e. the possibility to store file names in the native format of the current OS)

----------------------------------------
Bug #9618: Pathname#cleanpath creates mixed path separators
https://bugs.ruby-lang.org/issues/9618#change-45720

* Author: Daniel Rikowski
* Status: Open
* Priority: Low
* Assignee: cruby-windows
* Category: platform/windows
* Target version: 
* ruby -v: ruby 2.0.0p451 (2014-02-24) [i386-mingw32]
* Backport: 1.9.3: UNKNOWN, 2.0.0: UNKNOWN, 2.1: UNKNOWN
----------------------------------------
When using `Pathname#cleanpath` with a Windows path the resulting path contains a mixture of slashes and backslashes.

~~~
require 'pathname'
path = Pathname.new('c:\projects\ruby\bug\test.rb')
path.to_s               # => "c:\\projects\\ruby\\bug\\test.rb"
path.cleanpath.to_s     # => "c:\\projects/ruby/bug/test.rb"
~~~ 

I'd expect `cleanpath` to use the same path separator for all path segments. The problem doesn't happen on non-Windows platforms because there backslashes are not detected as path separators.

The problem is that the first path segment is added verbatim and only subsequent segments are joined by `File::join`.

Personally I'd prefer it to use `File::SEPARATOR` **only**, regardless of any original separator(s). That way it would blend with the current 'normalizing' behaviour of `cleanpath`, which then could be also used to normalize any existing separator weirdness and - for example - make a path compatible with `Dir.glob` (which can't use backslashes)





-- 
http://bugs.ruby-lang.org/

In This Thread

Prev Next