[#61424] [REJECT?] xmalloc/xfree: reduce atomic ops w/ thread-locals — Eric Wong <normalperson@...>

I'm unsure about this. I _hate_ the extra branches this adds;

13 messages 2014/03/12

[ruby-core:61231] Re: [ruby-trunk - Bug #9153] [Closed] IO#flush causes unnecessary fsync on Windows

From: "U.Nakamura" <usa@...>
Date: 2014-03-02 19:39:31 UTC
List: ruby-core #61231
Hi,

In message "Re: [ruby-trunk - Bug #9153] [Closed] IO#flush causes unnecessary fsync on Windows"
    on Mar.03,2014 04:30:36, <usa@garbagecollect.jp> wrote:
> > Ah, sorry, I can see now that it was already reverted. However it was
> > reverted together with #ifndef _WIN32. That #ifndef is not needed, i.e.
> > rb_thread_io_blocking_region(nogvl_fsync, fptr, fptr->fd) should be called
> > unconditionally.

Oops, I mistook!
You are completely right.


Regards,
-- 
U.Nakamura <usa@garbagecollect.jp>

In This Thread

Prev Next