From: "Юрий Соколов" <funny.falcon@...>
Date: 2012-11-22T18:09:27+09:00
Subject: [ruby-core:49871] Re: [ruby-trunk - Bug #7383] Use stricter cache check in load.c

--bcaec51b15f1d7cf2204cf11d2fe
Content-Type: text/plain; charset=ISO-8859-1

Hiroshi,

Adding size check is enough in this case.
But rb_ary_dup_of_p is more useful in the wild, I think.

With regards,
Yura

2012/11/19 h.shirosaki (Hiroshi Shirosaki) <h.shirosaki@gmail.com>

>
> Issue #7383 has been updated by h.shirosaki (Hiroshi Shirosaki).
>
> File 0001-Fix-cache-validity-check-of-require.patch added
>
> Yura, thank you.
> Indeed rb_ary_shared_with_p does not react against #shift or #pop.
> Original array remains shared with the snapshot.
> However, I think adding a check of array length would be sufficient for
> that. This fix has no performance impact, still O(1). I've attached a patch
> with tests.
> Are there any reasons that such a strict check is needed?
> ----------------------------------------
> Bug #7383: Use stricter cache check in load.c
> https://bugs.ruby-lang.org/issues/7383#change-33097
>
> Author: funny_falcon (Yura Sokolov)
> Status: Open
> Priority: High
> Assignee: h.shirosaki (Hiroshi Shirosaki)
> Category: core
> Target version: 2.0.0
> ruby -v: ruby 2.0.0dev (2012-11-18 trunk 37708) [x86_64-linux]
>
>
> rb_ary_shared_with_p does not react when #shift or #pop is called on
> original array.
>
> This patch introduce rb_ary_dup_of_p , which makes more adequate check for
> duplicate
> of array.
>
> https://github.com/ruby/ruby/pull/216
> https://github.com/ruby/ruby/pull/216.patch
>
>
> --
> http://bugs.ruby-lang.org/
>
>

--bcaec51b15f1d7cf2204cf11d2fe
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hiroshi,<br><br>Adding size check is enough in this case.<br>But rb_ary_dup=
_of_p is more useful in the wild, I think.<br><br>With regards,<br>Yura<br>=
<br><div class=3D"gmail_quote">2012/11/19 h.shirosaki (Hiroshi Shirosaki) <=
span dir=3D"ltr">&lt;<a href=3D"mailto:h.shirosaki@gmail.com" target=3D"_bl=
ank">h.shirosaki@gmail.com</a>&gt;</span><br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex"><br>
Issue #7383 has been updated by h.shirosaki (Hiroshi Shirosaki).<br>
<br>
File 0001-Fix-cache-validity-check-of-require.patch added<br>
<br>
Yura, thank you.<br>
Indeed rb_ary_shared_with_p does not react against #shift or #pop. Original=
 array remains shared with the snapshot.<br>
However, I think adding a check of array length would be sufficient for tha=
t. This fix has no performance impact, still O(1). I&#39;ve attached a patc=
h with tests.<br>
Are there any reasons that such a strict check is needed?<br>
<div class=3D"im">----------------------------------------<br>
Bug #7383: Use stricter cache check in load.c<br>
</div><a href=3D"https://bugs.ruby-lang.org/issues/7383#change-33097" targe=
t=3D"_blank">https://bugs.ruby-lang.org/issues/7383#change-33097</a><br>
<div class=3D"HOEnZb"><div class=3D"h5"><br>
Author: funny_falcon (Yura Sokolov)<br>
Status: Open<br>
Priority: High<br>
Assignee: h.shirosaki (Hiroshi Shirosaki)<br>
Category: core<br>
Target version: 2.0.0<br>
ruby -v: ruby 2.0.0dev (2012-11-18 trunk 37708) [x86_64-linux]<br>
<br>
<br>
rb_ary_shared_with_p does not react when #shift or #pop is called on origin=
al array.<br>
<br>
This patch introduce rb_ary_dup_of_p , which makes more adequate check for =
duplicate<br>
of array.<br>
<br>
<a href=3D"https://github.com/ruby/ruby/pull/216" target=3D"_blank">https:/=
/github.com/ruby/ruby/pull/216</a><br>
<a href=3D"https://github.com/ruby/ruby/pull/216.patch" target=3D"_blank">h=
ttps://github.com/ruby/ruby/pull/216.patch</a><br>
<br>
<br>
--<br>
<a href=3D"http://bugs.ruby-lang.org/" target=3D"_blank">http://bugs.ruby-l=
ang.org/</a><br>
<br>
</div></div></blockquote></div><br>

--bcaec51b15f1d7cf2204cf11d2fe--