From: Zachary Scott Date: 2012-11-16T03:13:47+09:00 Subject: [ruby-core:49389] Re: review open pull requests on github Mr. Lafortune, could you review #95 since you're maintainer of ostruct? On Thu, Nov 15, 2012 at 12:11 PM, Marc-Andre Lafortune wrote: > I could add my eyes to monitor the github issues/pull requests, if only to > ask the posters to open a redmine issue. I would need access to the github > repo though > > > On Wed, Nov 14, 2012 at 10:10 PM, Zachary Scott > wrote: >> >> Ok, I was hoping one of the maintainers might want to. >> >> I can go through and organize pull requests, and assign or update any >> associated tickets. >> >> >> On Wed, Nov 14, 2012 at 9:45 PM, NARUSE, Yui wrote: >> > 2012/11/15 Zachary Scott : >> >> Could we get a review on any open pull requests on github before the >> >> code freeze? >> >> >> >> There are a few that I think have been accepted, but not yet merged. >> > >> > Generally pull request on github is not correct place to report a bug >> > or suggest a feature. >> > >> > Anyway there are requests and some already got consensus to merge. >> > They should be merged. >> > But almost all of those which remain unmerged yet are not merged because >> > those maintainer don't see github. >> > We don't make them to watch github because they are not right place. >> > >> > So could you make a ticket to ask merging and assign to its maintainer. >> > https://bugs.ruby-lang.org/projects/ruby/wiki/Maintainers >> > >> > Thanks, >> > >> > -- >> > NARUSE, Yui >> > >> >