From: Trans <transfire@...>
Date: 2012-11-20T23:40:55+09:00
Subject: [ruby-core:49762] Re: [ruby-trunk - Feature #4085] Refinements and nested methods

--14dae934109f9af59904ceee386c
Content-Type: text/plain; charset=UTF-8

> This should return nil.  Otherwise, refinements can break code which
doesn't expect the refined behavior.

Ok. Makes sense.

> I don't understand why it's worse.

Only worse in that case if you had not said `nil`.

Since you did say `nil`, then what about:

    class S
      def foo
        "foo"
      end
      def bar
        "bar"
      end
      def foobar
        foo + bar
      end
    end

    module R
      refine S do
        def bar
          "bar!"
        end
      end
    end

    class C < S
      using R
      alias :foobar! :foobar
      def foobar?
        foo + bar
      end
      def brainfart1
        c = C.new
        c.foobar! == c.foobar?
      end
      def brainfart2
        c = C.new
        s = S.new
        c.foobar! == s.foobar
      end
      def brainfart3
        c = C.new
        s = S.new
        c.bar == s.bar
      end

    end

    C.new.brainfart1  #=> ?
    C.new.brainfart2  #=> ?
    C.new.brainfart3  #=> ?

--14dae934109f9af59904ceee386c
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<span style=3D"font-family:arial,sans-serif;font-size:13px">&gt; This shoul=
d return nil. =C2=A0Otherwise, refinements can break code which doesn&#39;t=
 expect the refined behavior.</span><div><span style=3D"font-family:arial,s=
ans-serif;font-size:13px"><br>
</span></div><div><span style=3D"font-family:arial,sans-serif;font-size:13p=
x">Ok. Makes sense.=C2=A0</span></div><div><span style=3D"font-family:arial=
,sans-serif;font-size:13px"><br></span><span style=3D"font-family:arial,san=
s-serif;font-size:13px">&gt; I don&#39;t understand why it&#39;s worse.</sp=
an><div>
<font face=3D"arial, sans-serif"><br></font></div><div><font face=3D"arial,=
 sans-serif">Only worse in that case if you had not said `nil`.</font></div=
><div><font face=3D"arial, sans-serif"><br></font></div><div><font face=3D"=
arial, sans-serif">Since you did say `nil`, then what about:</font></div>
<div><div><br></div><div><div>=C2=A0 =C2=A0 class S</div><div>=C2=A0 =C2=A0=
 =C2=A0 def foo</div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 &quot;foo&quot; =C2=
=A0 =C2=A0 =C2=A0</div><div>=C2=A0 =C2=A0 =C2=A0 end</div><div><div>=C2=A0 =
=C2=A0 =C2=A0 def bar</div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 &quot;bar&quot;=
 =C2=A0 =C2=A0 =C2=A0</div><div>=C2=A0 =C2=A0 =C2=A0 end</div></div>
<div>=C2=A0 =C2=A0 =C2=A0 def foobar</div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =
foo + bar</div><div>=C2=A0 =C2=A0 =C2=A0 end</div><div>=C2=A0 =C2=A0 end<br=
></div></div><div><br></div><div><span style=3D"color:rgb(80,0,80);font-fam=
ily:arial,sans-serif;font-size:13px">=C2=A0 =C2=A0 module R</span><br style=
=3D"color:rgb(80,0,80);font-family:arial,sans-serif;font-size:13px">
<span style=3D"color:rgb(80,0,80);font-family:arial,sans-serif;font-size:13=
px">=C2=A0 =C2=A0 =C2=A0 refine S do</span><br style=3D"color:rgb(80,0,80);=
font-family:arial,sans-serif;font-size:13px"><span style=3D"color:rgb(80,0,=
80);font-family:arial,sans-serif;font-size:13px">=C2=A0 =C2=A0 =C2=A0 =C2=
=A0 def bar</span><br style=3D"color:rgb(80,0,80);font-family:arial,sans-se=
rif;font-size:13px">
<span style=3D"color:rgb(80,0,80);font-family:arial,sans-serif;font-size:13=
px">=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 &quot;bar!&quot;</span><br style=3D"=
color:rgb(80,0,80);font-family:arial,sans-serif;font-size:13px"><span style=
=3D"color:rgb(80,0,80);font-family:arial,sans-serif;font-size:13px">=C2=A0 =
=C2=A0 =C2=A0 =C2=A0 end</span><br style=3D"color:rgb(80,0,80);font-family:=
arial,sans-serif;font-size:13px">
<span style=3D"color:rgb(80,0,80);font-family:arial,sans-serif;font-size:13=
px">=C2=A0 =C2=A0 =C2=A0 end</span><br style=3D"color:rgb(80,0,80);font-fam=
ily:arial,sans-serif;font-size:13px"><span style=3D"color:rgb(80,0,80);font=
-family:arial,sans-serif;font-size:13px">=C2=A0 =C2=A0 end</span><br>
</div><div><br></div><div><div>=C2=A0 =C2=A0 class C &lt; S</div><div>=C2=
=A0 =C2=A0 =C2=A0 using R</div><div>=C2=A0 =C2=A0 =C2=A0 alias :foobar! :fo=
obar<br></div><div>=C2=A0 =C2=A0 =C2=A0 def foobar?<br></div><div>=C2=A0 =
=C2=A0 =C2=A0 =C2=A0 foo + bar</div><div>=C2=A0 =C2=A0 =C2=A0 end</div><div=
>=C2=A0 =C2=A0 =C2=A0 def brainfart1<br>
</div><div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 c =3D C.new</div><div>=C2=A0 =
=C2=A0 =C2=A0 =C2=A0 c.foobar! =3D=3D c.foobar?<br></div><div>=C2=A0 =C2=A0=
 =C2=A0 end</div></div><div><div>=C2=A0 =C2=A0 =C2=A0 def brainfart2<br></d=
iv><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 c =3D C.new</div><div>=C2=A0 =C2=A0 =C2=
=A0 =C2=A0 s =3D S.new</div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 c.foobar! =3D=
=3D s.foobar</div>
<div>=C2=A0 =C2=A0 =C2=A0 end</div></div><div><div>=C2=A0 =C2=A0 =C2=A0 def=
 brainfart3<br></div><div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 c =3D C.new</div><div=
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 s =3D S.new</div><div>=C2=A0 =C2=A0 =C2=A0 =C2=
=A0 c.bar =3D=3D s.bar</div><div>=C2=A0 =C2=A0 =C2=A0 end</div></div><div><=
br></div><div>=C2=A0 =C2=A0 end<br></div></div>
<div><br></div><div>=C2=A0 =C2=A0 C.new.brainfart1 =C2=A0#=3D&gt; ?</div><d=
iv>=C2=A0 =C2=A0 C.new.brainfart2 =C2=A0#=3D&gt; ?<br></div><div>=C2=A0 =C2=
=A0 C.new.brainfart3 =C2=A0#=3D&gt; ?<br></div><div><br></div></div></div><=
div class=3D"gmail_extra"><br><br>
</div>

--14dae934109f9af59904ceee386c--