From: Trans <transfire@...>
Date: 2012-11-16T04:59:06+09:00
Subject: [ruby-core:49394] Re: review open pull requests on github

--f46d0447f1be49fd5204ce8e157d
Content-Type: text/plain; charset=UTF-8

FYI. I think there is still room for improvement in the implementation of
OpenStruct, but I can reintroduce this in a future issue.


On Thu, Nov 15, 2012 at 1:55 PM, Marc-Andre Lafortune <
ruby-core-mailing-list@marc-andre.ca> wrote:

>
>
> On Thu, Nov 15, 2012 at 1:06 PM, Zachary Scott <zachary@zacharyscott.net>
>  wrote:
>
>> Right, but if Mr. Lafortune wants to help maintain pull requests on
>> github, he needs a commit bit to be repo collab.
>>
>
> Indeed, I understand we can't accept pull requests directly :-(
>
> > could you review #95 since you're maintainer of ostruct?
>
> I already commented on it; I believe it is now obsolete inasmuch as most
> of it has already been implemented and committed. I'll close it and
> comments on it.
>
>


-- 
Sorry, says the barman, we don't serve neutrinos. A neutrino walks into a
bar.

Trans <transfire@gmail.com>
7r4n5.com      http://7r4n5.com

--f46d0447f1be49fd5204ce8e157d
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

FYI. I think there is still room for improvement in the implementation of O=
penStruct, but I can reintroduce this in a future issue.<div class=3D"gmail=
_extra"><br><br><div class=3D"gmail_quote">On Thu, Nov 15, 2012 at 1:55 PM,=
 Marc-Andre Lafortune <span dir=3D"ltr">&lt;<a href=3D"mailto:ruby-core-mai=
ling-list@marc-andre.ca" target=3D"_blank">ruby-core-mailing-list@marc-andr=
e.ca</a>&gt;</span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex"><div class=3D"gmail_quote"><div><span style=
=3D"border-collapse:separate"><br><br><div class=3D"gmail_quote"><font colo=
r=3D"#000000">On Thu, Nov 15, 2012 at 1:06 PM, Zachary Scott=C2=A0</font><s=
pan dir=3D"ltr" style>&lt;<a href=3D"mailto:zachary@zacharyscott.net" targe=
t=3D"_blank">zachary@zacharyscott.net</a>&gt;</span><font color=3D"#000000"=
>=C2=A0wrote:</font><br>


<blockquote class=3D"gmail_quote" style=3D"margin-top:0px;margin-right:0px;=
margin-bottom:0px;margin-left:0.8ex;border-left-width:1px;border-left-color=
:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div>

<span style>Right, but if Mr. Lafortune wants to help maintain pull request=
s on</span><br></div><font color=3D"#000000">github, he needs a commit bit =
to be repo collab.</font><br>

</blockquote><div style><br></div><div style>Indeed, I understand we can&#3=
9;t accept pull requests directly :-(</div><div style><br></div><div style>

&gt;=C2=A0<span style=3D"border-collapse:collapse;color:rgb(34,34,34);font-=
family:arial,sans-serif;font-size:13px">could you review #95 since you&#39;=
re maintainer of ostruct?</span></div><div style>
<br>
</div><div style>I already commented on it; I believe it is now obsolete in=
asmuch as most of it has already been implemented and committed. I&#39;ll c=
lose it and comments on it.</div><div style>

<br></div></div></span></div></div>
</blockquote></div><br><br clear=3D"all"><div><br></div>-- <br>Sorry, says =
the barman, we don&#39;t serve neutrinos. A neutrino walks into a bar.<br><=
br>Trans &lt;<a href=3D"mailto:transfire@gmail.com" target=3D"_blank">trans=
fire@gmail.com</a>&gt;<br>
<a href=3D"http://7r4n5.com" target=3D"_blank">7r4n5.com</a>=C2=A0 =C2=A0 =
=C2=A0 <a href=3D"http://7r4n5.com" target=3D"_blank">http://7r4n5.com</a><=
br><br><br><br>
</div>

--f46d0447f1be49fd5204ce8e157d--