[#4522] Undefined Errno::EPROTO and the like raises NameError — "Florian Frank" <flori@...>
Hi,
5 messages
2005/03/07
[#4533] giving acces readline to rl_line_buffer — "Cs. Henk" <csaba-ml@...>
Hi!
1 message
2005/03/09
[#4548] Ruby 1.8.2 array of hash entries functions incorrectly — noreply@...
Bugs item #1613, was opened at 2005-03-09 19:49
4 messages
2005/03/10
[#4561] rb_reg_quote weirdness — Nikolai Weibull <mailing-lists.ruby-core@...>
(Two weirdnesses in one day.)
5 messages
2005/03/13
[#4564] Re: rb_reg_quote weirdness
— Yukihiro Matsumoto <matz@...>
2005/03/14
Hi,
[#4567] Immutable Ropes — Nikolai Weibull <mailing-lists.ruby-core@...>
Note how I didn't write "Immutable Strings" in the subject.
8 messages
2005/03/15
[#4573] Re: Immutable Ropes
— Mathieu Bouchard <matju@...>
2005/03/15
[#4575] Allowing "?" in struct members — "Berger, Daniel" <Daniel.Berger@...>
Hi all,
8 messages
2005/03/16
[#4587] 0**0==1? — Bertram Scharpf <lists@...>
Hi,
6 messages
2005/03/19
[#4595] New block syntax — Daniel Amelang <daniel.amelang@...>
I'm really sorry if this isn't the place to talk about this. I've
25 messages
2005/03/21
[#4597] Re: New block syntax
— Florian Gro<florgro@...>
2005/03/21
Daniel Amelang wrote:
[#4606] Re: New block syntax
— "David A. Black" <dblack@...>
2005/03/21
Hi --
[#4629] Re: New block syntax
— "Sean E. Russell" <ser@...>
2005/03/30
On Monday 21 March 2005 16:17, David A. Black wrote:
[#4631] Re: New block syntax
— "David A. Black" <dblack@...>
2005/03/30
Hi --
[#4633] Re: New block syntax
— Daniel Amelang <daniel.amelang@...>
2005/03/31
Hey David, I think that we've had some misunderstandings due to
[#4634] Re: New block syntax
— "David A. Black" <dblack@...>
2005/03/31
Hi --
[#4639] Re: New block syntax
— "Sean E. Russell" <ser@...>
2005/03/31
On Wednesday 30 March 2005 20:55, David A. Black wrote:
[#4628] Re: New block syntax
— "Sean E. Russell" <ser@...>
2005/03/30
On Sunday 20 March 2005 21:31, Daniel Amelang wrote:
[#4601] Re: New block syntax — "Berger, Daniel" <Daniel.Berger@...>
> -----Original Message-----
5 messages
2005/03/21
[#4611] want_object? - possible? — "Berger, Daniel" <Daniel.Berger@...>
Hi all,
4 messages
2005/03/22
[#4619] Re: want_object? - possible? — Daniel Berger <djberg96@...>
--- nobu.nokada@softhome.net wrote:
9 messages
2005/03/25
[#4620] Re: want_object? - possible?
— "David A. Black" <dblack@...>
2005/03/25
Hi --
[#4711] Re: want_object? - possible?
— Mark Hubbart <discordantus@...>
2005/04/14
On 3/24/05, David A. Black <dblack@wobblini.net> wrote:
[#4717] Re: want_object? - possible?
— "David A. Black" <dblack@...>
2005/04/14
Hi --
[#4718] Re: want_object? - possible?
— Mark Hubbart <discordantus@...>
2005/04/15
On 4/14/05, David A. Black <dblack@wobblini.net> wrote:
[#4719] return_value? [Was: Re: want_object? - possible?]
— Eric Hodel <drbrain@...7.net>
2005/04/15
On 14 Apr 2005, at 22:20, Mark Hubbart wrote:
[#4724] Re: return_value? [Was: Re: want_object? - possible?]
— Mark Hubbart <discordantus@...>
2005/04/15
On 4/15/05, Eric Hodel <drbrain@segment7.net> wrote:
[#4622] tempfile.rb — Tilman Sauerbeck <tilman@...>
Hi,
4 messages
2005/03/26
[#4648] about REXML::Encoding — speakillof <speakillof@...>
Hi.
15 messages
2005/03/31
[#4659] Re: about REXML::Encoding
— "Sean E. Russell" <ser@...>
2005/04/04
On Thursday 31 March 2005 09:44, speakillof wrote:
[#4661] Re: about REXML::Encoding
— speakillof <speakillof@...>
2005/04/04
Hi.
[#4684] Re: about REXML::Encoding
— "Sean E. Russell" <ser@...>
2005/04/09
I've tested, applied, and committed your Encoding patch, Nobu.
[#4688] Re: about REXML::Encoding
— nobu.nokada@...
2005/04/10
Hi,
[PATCH] tempfile.rb
From:
Tilman Sauerbeck <tilman@...>
Date:
2005-03-26 17:49:40 UTC
List:
ruby-core #4622
Hi,
there's a bug in Ruby 1.8.2 that breaks the following code:
require "tempfile"
Tempfile.open("foo.rb") do |f|
# do stuff with tf
# make sure the file gets removed as soon as the block
# terminates:
f.unlink # this leads to an exception
end
/usr/lib/ruby/1.8/tempfile.rb:84:in `_close': undefined method `[]=' for nil:NilClass (NoMethodError)
from /usr/lib/ruby/1.8/tempfile.rb:97:in `close'
from /usr/lib/ruby/1.8/tempfile.rb:174:in `open'
This was then fixed in CVS by making Tempfile#_close only set @data[1]
to nil if @data isn't nil.
I suspect that this isn't the right way to fix it, maybe it's better to
only set @data[1] to nil instead of @data in #unlink (and #close!)?
Attached a diff against CVS HEAD.
--
Regards,
Tilman
Attachments (1)
ruby-tempfile.diff
(1014 Bytes, text/x-diff)
Index: lib/tempfile.rb
===================================================================
RCS file: /src/ruby/lib/tempfile.rb,v
retrieving revision 1.27
diff -u -r1.27 tempfile.rb
--- lib/tempfile.rb 15 Nov 2004 16:45:02 -0000 1.27
+++ lib/tempfile.rb 26 Mar 2005 17:41:17 -0000
@@ -81,8 +81,7 @@
def _close # :nodoc:
@tmpfile.close if @tmpfile
- @tmpfile = nil
- @data[1] = nil if @data
+ @data[1] = @tmpfile = nil
end
protected :_close
@@ -104,7 +103,7 @@
_close
@clean_proc.call
ObjectSpace.undefine_finalizer(self)
- @data = @tmpname = nil
+ @data[1] = @tmpname = nil
end
# Unlinks the file. On UNIX-like systems, it is often a good idea
@@ -116,7 +115,7 @@
begin
File.unlink(@tmpname) if File.exist?(@tmpname)
@@cleanlist.delete(@tmpname)
- @data = @tmpname = nil
+ @data[1] = @tmpname = nil
ObjectSpace.undefine_finalizer(self)
rescue Errno::EACCESS
# may not be able to unlink on Windows; just ignore