Re: [patch] logger.rb - allowing logger to be innitialized in a single line

> -----Original Message-----
> From: Sam Roberts [mailto:[e-mail]] 
> Sent: Wednesday, March 09, 2005 1:57 PM
> To: ruby-core
> Subject: [patch] logger.rb - allowing logger to be 
> innitialized in a single line
> 
> 
> 
> I wanted to do:
> 
>    SomeClass.logger = Logger.new(name, shift_age = 'weekly') 
> { |l| l.level = Logger::ERROR }
> 
> not
> 
>    alogger = Logger.new(name, shift_age = 'weekly')
>    alogger.level = Logger::ERROR
>    SomeClass.logger = alogger

<snip>

Hm...how about this modification?

--- logger.orig	Wed Mar  9 14:03:35 2005
+++ logger.rb	Wed Mar  9 14:02:32 2005
@@ -246,6 +246,8 @@
   # Create an instance.  See Logger::LogDevice.new for more information
if
   # required.
   #
+  attr_accessor :logdev, :shift_age, :shift_size
+  attr_reader :level
   def initialize(logdev, shift_age = 0, shift_size = 1048576)
     @logdev = nil
     @progname = nil
@@ -252,6 +254,7 @@
     @level = DEBUG
     @datetime_format = nil
     @logdev = nil
+    yield self if block_given?
     if logdev
       @logdev = LogDevice.new(logdev, :shift_age => shift_age,
:shift_size => shift_size)
     end

This is similar, but it's a little cleaner I think.  I also provides
accessors for logdev, shift_age and shift_size, as well as a reader for
level, which all appear to be missing.

Regards,

Dan