From: "Berger, Daniel" <Daniel.Berger@...>
Date: 2005-03-10T06:56:53+09:00
Subject: Re: [patch] logger.rb - allowing logger to be innitialized in a single line

Hi,

> -----Original Message-----
> From: Sam Roberts [mailto:sroberts@uniserve.com] 
> 
> Sure, how about some docs? :-)
> 
> Sam

Ok.  Also, I guess there is an attr_accessor for 'level' already, so we
don't need that.  I arranged the code and docs this way to keep with the
way the original author has them laid out:

227,235d226
<   # The log device (IO Handle or String).
<   attr_accessor :logdev
< 
<   # The number of old files to kee or frequency of rotation
<   attr_accessor :shift_age
< 
<   # The maximum logfile size
<   attr_accessor :shift_size
< 
241d231
<   #   Logger.new{ |log| ... }
256,258c246,247
<   # Creates and returns a Logger instance.  If a block is provided,
yields a Logger
<   # instance to the block which you can use to set attributes.
Attributes set this
<   # way will override any arguments passed to the constructor.
---
>   # Create an instance.  See Logger::LogDevice.new for more
information if
>   # required.
260,261d248
<   # See Logger::LogDevice.new for more information if required.
<   #
268d254
<     yield self if block_given?

Look good?

Regards,

Dan