[ruby-core:35337] [Ruby 1.9-Bug#3972] r28668 breaks test/unit when combined with the testing rake task

Issue #3972 has been updated by Tomoyuki Chikanaga.


Hi,

After r30913, make test-all output warning and testunit message in test_rake_integration.rb like follows.

.../path/to/src/lib/test/unit.rb:43: warning: instance variable @options not initialized
Run options: 

# Running tests:



Finished tests in 0.000475s, 0.0000 tests/s, 0.0000 assertions/s.

0 tests, 0 assertions, 0 failures, 0 errors, 0 skips
.....

Aaron san, What do you think about the following patch? Is it OK to @options = nil in Options#initialize?

diff --git a/lib/test/unit.rb b/lib/test/unit.rb
index 1272153..49c4e51 100644
--- a/lib/test/unit.rb
+++ b/lib/test/unit.rb
@@ -32,6 +32,7 @@ module Test
     module Options
       def initialize(*, &block)
         @init_hook = block
+        @options = nil
         super(&nil)
       end
 
diff --git a/test/testunit/test_rake_integration.rb b/test/testunit/test_rake_integration.rb
index bb0951d..86a0cf8 100644
--- a/test/testunit/test_rake_integration.rb
+++ b/test/testunit/test_rake_integration.rb
@@ -24,7 +24,12 @@ class FooTest; end
         eotest
       end
 
-      assert_ruby_status(%w{ -w } + [RAKE_LOADER, filename])
+      args = %w{ -w } + [RAKE_LOADER, filename]
+      bug3972 = "[ruby-core:32864]"
+      status = assert_in_out_err(args, "",
+                    /0 tests, 0 assertions, 0 failures, 0 errors, 0 skips/,
+                    [], bug3972)
+      assert_equal(true, status.success?, bug3972)
     end
   end
 end

----------------------------------------
http://redmine.ruby-lang.org/issues/show/3972

----------------------------------------
http://redmine.ruby-lang.org