ruby-core



Hello Rubyists.

I'm a long-time user of ruby-mode.el, which provides Ruby support for
Emacs. Recently I have started using mumamo, which is an Emacs mode for
embedding other Emacs modes inside HTML templates (a common practice
using ERB). I was having some problems with the font-lock (aka syntax
highlighting) in these buffers, and the author of mumamo advised me that
it was due to some bugs in ruby-mode.el. Specifically the fact that it
adds fontification rules in a hook was causing issues.

I have a patch attached which moves the relevant fontification rules to
the body of the ruby-mode function, but I was unable to understand why
they were in a hook to begin with. I have used this modified ruby-mode
for a few days without any problems--it also solves the mumamo problem.

I hope this patch can be applied.

I have noticed there are a number of constructs in ruby-mode.el that are
rather un-idiomatic examples of elisp, as well as some constructs that
exist to support extremely old versions of Emacs. I have been thinking
about going through and cleaning that up if that is desirable.

Also, I have heard a rumor that ruby-mode.el is to be submitted for
inclusion with Emacs. What is the status on this?

thanks,
Phil Hagelberg
http://technomancy.us

Attachments (1)

ruby-mode-fontification.patch (1.86 KB, text/x-diff)

Index: ruby-mode.el
===================================================================
--- ruby-mode.el	(revision 16262)
+++ ruby-mode.el	(working copy)
@@ -307,6 +307,11 @@
 	 ((boundp 'write-contents-hooks) 'write-contents-hooks))
    'ruby-mode-set-encoding)
 
+  (set (make-local-variable 'font-lock-defaults) '((ruby-font-lock-keywords) nil nil))
+  (set (make-local-variable 'font-lock-keywords) ruby-font-lock-keywords)
+  (set (make-local-variable 'font-lock-syntax-table) ruby-font-lock-syntax-table)
+  (set (make-local-variable 'font-lock-syntactic-keywords) ruby-font-lock-syntactic-keywords)
+
   (run-mode-hooks 'ruby-mode-hook))
 
 (defun ruby-current-indentation ()
@@ -1101,24 +1106,13 @@
 	  ("^\\(=\\)begin\\(\\s \\|$\\)" 1 (7 . nil))
 	  ("^\\(=\\)end\\(\\s \\|$\\)" 1 (7 . nil))))
 
-  (cond ((featurep 'xemacs)
-	 (put 'ruby-mode 'font-lock-defaults
-	      '((ruby-font-lock-keywords)
-		nil nil nil
-		beginning-of-line
-		(font-lock-syntactic-keywords
-		 . ruby-font-lock-syntactic-keywords))))
-	(t
-	 (add-hook 'ruby-mode-hook
-	    '(lambda ()
-	       (make-local-variable 'font-lock-defaults)
-	       (make-local-variable 'font-lock-keywords)
-	       (make-local-variable 'font-lock-syntax-table)
-	       (make-local-variable 'font-lock-syntactic-keywords)
-	       (setq font-lock-defaults '((ruby-font-lock-keywords) nil nil))
-	       (setq font-lock-keywords ruby-font-lock-keywords)
-	       (setq font-lock-syntax-table ruby-font-lock-syntax-table)
-	       (setq font-lock-syntactic-keywords ruby-font-lock-syntactic-keywords)))))
+  (if (featurep 'xemacs)
+      (put 'ruby-mode 'font-lock-defaults
+	   '((ruby-font-lock-keywords)
+	     nil nil nil
+	     beginning-of-line
+	     (font-lock-syntactic-keywords
+	      . ruby-font-lock-syntactic-keywords))))
 
   (defun ruby-font-lock-docs (limit)
     (if (re-search-forward "^=begin\\(\\s \\|$\\)" limit t)

Thread

Prev Next

In This Thread

Prev Next