From: "hsbt (Hiroshi SHIBATA) via ruby-core" <ruby-core@...>
Date: 2023-01-23T02:13:49+00:00
Subject: [ruby-core:111981] [Ruby master Bug#19364] Issue with tracepoint enable/disable across ractors

Issue #19364 has been updated by hsbt (Hiroshi SHIBATA).

Status changed from Open to Assigned
Assignee set to ko1 (Koichi Sasada)

----------------------------------------
Bug #19364: Issue with tracepoint enable/disable across ractors
https://bugs.ruby-lang.org/issues/19364#change-101417

* Author: luke-gru (Luke Gruber)
* Status: Assigned
* Priority: Normal
* Assignee: ko1 (Koichi Sasada)
* Backport: 2.7: UNKNOWN, 3.0: UNKNOWN, 3.1: UNKNOWN, 3.2: UNKNOWN
----------------------------------------
This sometimes segfaults:
```ruby
def test_enable_disable_in_multiple_ractors_with_target
  rs = []
  100.times do |i|
    # setup new iseqs
    Kernel.define_method :"my_method_to_change_for_tracing_#{i}" do
      true
    end
  end
  100.times do |i|
    rs << Ractor.new(i) do |j|
      meth = :"my_method_to_change_for_tracing_#{j}"
      tp = TracePoint.new(:line) { } # local to ractor
      100.times do
        tp.enable(target: method(meth)) # change iseq internals of given method, should be done with lock
        tp.disable # disable hooks should hold lock too, changes method definition internals
      end
    end
  end
  rs.each(&:take) # shouldn't raise
end
test_enable_disable_in_multiple_ractors_with_target()
```

Changing iseq internals is done without the VM lock. This is true in Tracepoint#enable and Tracepoint#disable methods.
I have a patch coming.



-- 
https://bugs.ruby-lang.org/
 ______________________________________________
 ruby-core mailing list -- ruby-core@ml.ruby-lang.org
 To unsubscribe send an email to ruby-core-leave@ml.ruby-lang.org
 ruby-core info -- https://ml.ruby-lang.org/mailman3/postorius/lists/ruby-core.ml.ruby-lang.org/