[ruby-dev:25319] Re: IO.select dumps core

なかだです。

At Sat, 25 Dec 2004 00:00:00 +0900,
Tanaka Akira wrote in [ruby-dev:25312]:
> 
> 次のようにすると core を吐きます。
> 
> % ./ruby -e '
> r, w = IO.pipe
> w << "a"
> io = Object.new
> rs = [r] * 0x20000 + [io]
> actions = [
>   lambda { r },
>   lambda { rs.replace []; r }
> ]
> class << io; self end.send(:define_method, :to_io) {
>   actions.shift.call
> }
> a,b,c = IO.select(rs, nil, nil, 0)
> '
> -e:13: [BUG] Segmentation fault
> ruby 1.9.0 (2004-12-24) [i686-linux]

それぞれ二回ずつIOへの変換をするのも気になりますが。


Index: io.c
===================================================================
RCS file: /cvs/ruby/src/ruby/io.c,v
retrieving revision 1.355
diff -U2 -p -r1.355 io.c
--- io.c	23 Dec 2004 18:06:19 -0000	1.355
+++ io.c	25 Dec 2004 05:35:16 -0000
@@ -4568,11 +4568,12 @@ rb_f_select(argc, argv, obj)
 
     if (interrupt_flag == 0) {
+	VALUE io;
 	if (rp) {
 	    list = RARRAY(res)->ptr[0];
 	    for (i=0; i< RARRAY(read)->len; i++) {
-		GetOpenFile(rb_io_get_io(RARRAY(read)->ptr[i]), fptr);
+		GetOpenFile(rb_io_get_io(io = RARRAY(read)->ptr[i]), fptr);
 		if (FD_ISSET(fptr->fd, rp)
 		    || FD_ISSET(fptr->fd, &pset)) {
-		    rb_ary_push(list, RARRAY(read)->ptr[i]);
+		    rb_ary_push(list, io);
 		}
 	    }
@@ -4582,7 +4583,7 @@ rb_f_select(argc, argv, obj)
 	    list = RARRAY(res)->ptr[1];
 	    for (i=0; i< RARRAY(write)->len; i++) {
-		GetOpenFile(rb_io_get_io(RARRAY(write)->ptr[i]), fptr);
+		GetOpenFile(rb_io_get_io(io = RARRAY(write)->ptr[i]), fptr);
 		if (FD_ISSET(fptr->fd, wp)) {
-		    rb_ary_push(list, RARRAY(write)->ptr[i]);
+		    rb_ary_push(list, io);
 		}
 	    }
@@ -4592,7 +4593,7 @@ rb_f_select(argc, argv, obj)
 	    list = RARRAY(res)->ptr[2];
 	    for (i=0; i< RARRAY(except)->len; i++) {
-		GetOpenFile(rb_io_get_io(RARRAY(except)->ptr[i]), fptr);
+		GetOpenFile(rb_io_get_io(io = RARRAY(except)->ptr[i]), fptr);
 		if (FD_ISSET(fptr->fd, ep)) {
-		    rb_ary_push(list, RARRAY(except)->ptr[i]);
+		    rb_ary_push(list, io);
 		}
 	    }


-- 
--- 僕の前にBugはない。
--- 僕の後ろにBugはできる。
    中田 伸悦