[ruby-dev:25162] Re: Curses::Window#subwin dumps core

前田です。

Tanaka Akira wrote:
> 次のようにすると core を吐きます。
> 
> % ./ruby -rcurses -e '
> include Curses
> init_screen
> w = stdscr
> h = Object.new
> class << h; self end.send(:define_method, :to_int) {
>   w.close
>   10
> }
> w2 = w.subwin h, 20, 3, 3' > /dev/null
> -e:10: [BUG] Segmentation fault
>                                ruby 1.9.0 (2004-12-12) [i686-linux]
> 

HEADで修正しました。

Index: ext/curses/curses.c
===================================================================
RCS file: /var/cvs/src/ruby/ext/curses/curses.c,v
retrieving revision 1.25
retrieving revision 1.26
diff -u -r1.25 -r1.26
--- ext/curses/curses.c	27 Jan 2004 06:04:55 -0000	1.25
+++ ext/curses/curses.c	12 Dec 2004 17:47:53 -0000	1.26
@@ -1,5 +1,5 @@
 /* -*- C -*-
- * $Id: curses.c,v 1.25 2004/01/27 06:04:55 matz Exp $
+ * $Id: curses.c,v 1.26 2004/12/12 17:47:53 shugo Exp $
  *
  * ext/curses/curses.c
  *
@@ -766,22 +766,26 @@
     return obj;
 }

-/* def subwin(h, w, top, left) */
+/* def subwin(height, width, top, left) */
 static VALUE
-window_subwin(obj, h, w, top, left)
+window_subwin(obj, height, width, top, left)
     VALUE obj;
-    VALUE h;
-    VALUE w;
+    VALUE height;
+    VALUE width;
     VALUE top;
     VALUE left;
 {
     struct windata *winp;
     WINDOW *window;
     VALUE win;
+    int h, w, t, l;

+    h = NUM2INT(height);
+    w = NUM2INT(width);
+    t = NUM2INT(top);
+    l = NUM2INT(left);
     GetWINDOW(obj, winp);
-    window = subwin(winp->window, NUM2INT(h), NUM2INT(w),
-		                  NUM2INT(top), NUM2INT(left));
+    window = subwin(winp->window, h, w, t, l);
     win = prep_window(rb_obj_class(obj), window);

     return win;

-- 
前田 修吾