From: cremno@... Date: 2016-03-22T15:34:38+00:00 Subject: [ruby-core:74490] [Ruby trunk Misc#12205] update missing/strl{cat, cpy}.c Issue #12205 has been updated by cremno phobia. Shyouhei Urabe wrote: > The code is much cleaner so I would +1, but it seems the upstream has more recent revisions (strlcat.c 1.16 and strlcpy.c 1.13). Why to avoid them? The current revisions would require defining a function-like macro called `DEF_WEAK` (which originally defines a weak alias): http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib/libc/string/strlcat.c.diff?r1=1.15&r2=1.16&f=h http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib/libc/string/strlcpy.c.diff?r1=1.12&r2=1.13&f=h But CRuby isn't a libc implementation. Possible namespace violations can be solved by e.g. renaming `strl*` to `ruby_strl*`. ---------------------------------------- Misc #12205: update missing/strl{cat,cpy}.c https://bugs.ruby-lang.org/issues/12205#change-57611 * Author: cremno phobia * Status: Open * Priority: Normal * Assignee: ---------------------------------------- The attached git diff updates `missing/strlcat.c` from 1.8 to 1.15, `missing/strlcpy.c` from 1.5 to 1.12 and also the `LEGAL` file. There is no important reason. But there was a license change: new style-BSD to a less restrictive ISC-style license. Other changes include improving code readability and modernizing (function prototypes, no `register`) Upstream URLs (if you're looking for more details): http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib/libc/string/strlcat.c http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib/libc/string/strlcpy.c ---Files-------------------------------- update-strl.diff (11.1 KB) -- https://bugs.ruby-lang.org/ Unsubscribe: