From: Kenta Murata Date: 2016-03-19T16:00:54+00:00 Subject: [ruby-core:74467] Re: [ruby-cvs:61324] mrkn:r54163 (trunk): * bignum.c (rb_big_even_p, rb_big_odd_p): make them public functions --===============0789088955== Content-Type: multipart/alternative; boundary=089e012946147d949d052e68f8f7 --089e012946147d949d052e68f8f7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I fully agree with what you pointed out. Thanks for your advice. 2016=E5=B9=B43=E6=9C=8818=E6=97=A5(=E9=87=91) 10:31 Tanaka Akira : > 2016-03-18 2:07 GMT+09:00 : > > mrkn 2016-03-18 02:07:29 +0900 (Fri, 18 Mar 2016) > > > > New Revision: 54163 > > > * include/ruby/intern.h (rb_big_even_p, rb_big_odd_p): add prototyp= e > > declarations. > > I recommend internal.h instead of include/ruby/intern.h. > internal.h is the header file only for ruby itself. > intern.h is the header file exported to applications. > > Since a function declared in intern.h is exported to applications, > it is difficult to remove it even if ruby itself doesn't use it. > -- > Tanaka Akira > --089e012946147d949d052e68f8f7 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I fully agree with what you pointed out.
Th= anks for your advice.


2016=E5=B9=B43=E6=9C=8818=E6=97=A5(=E9=87=91) 10:3= 1 Tanaka Akira <akr@fsij.org>:
2016-03-18 2:07 GMT+09:00=C2=A0 <<= a href=3D"mailto:mrkn@ruby-lang.org" target=3D"_blank">mrkn@ruby-lang.org>:
> mrkn=C2=A0 =C2=A0 2016-03-18 02:07:29 +0900 (Fri, 18 Mar 2016)
>
>=C2=A0 =C2=A0New Revision: 54163

>=C2=A0 =C2=A0 =C2=A0* include/ruby/intern.h (rb_big_even_p, rb_big_odd_= p): add prototype
>=C2=A0 =C2=A0 =C2=A0 =C2=A0declarations.

I recommend internal.h instead of include/ruby/intern.h.
internal.h is the header file only for ruby itself.
intern.h is the header file exported to applications.

Since a function declared in intern.h is exported to applications,
it is difficult to remove it even if ruby itself doesn't use it.
--
Tanaka Akira
--089e012946147d949d052e68f8f7-- --===============0789088955== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline Unsubscribe: --===============0789088955==--