From: shyouhei@... Date: 2016-03-22T11:49:00+00:00 Subject: [ruby-core:74488] [Ruby trunk Bug#12203][Assigned] dumper.c static int yaml_emitter_dump_scalar two variables have the same value Issue #12203 has been updated by Shyouhei Urabe. Status changed from Open to Assigned Assignee set to Aaron Patterson They are passed to a macro. I guess the author intentionally separated these two because merging them makes the code less intuitive. It seems OK to be optimized. ---------------------------------------- Bug #12203: dumper.c static int yaml_emitter_dump_scalar two variables have the same value https://bugs.ruby-lang.org/issues/12203#change-57609 * Author: Anton Sivakov * Status: Assigned * Priority: Normal * Assignee: Aaron Patterson * ruby -v: * Backport: 2.1: UNKNOWN, 2.2: UNKNOWN, 2.3: UNKNOWN ---------------------------------------- ~~~ static int yaml_emitter_dump_scalar( ..... int plain_implicit = (strcmp((char *)node->tag, YAML_DEFAULT_SCALAR_TAG) == 0); int quoted_implicit = (strcmp((char *)node->tag, YAML_DEFAULT_SCALAR_TAG) == 0); ~~~ variables 'plain_implicit' and 'quoted_implicit' have the same values. It possible wrong expression or this code can be optimized. -- https://bugs.ruby-lang.org/ Unsubscribe: