[ruby-core:46537] Re: [ruby-trunk - Bug #6724][Open] waaaaaaant! (

On Thu, Jul 12, 2012 at 08:58:36AM +0900, zenspider (Ryan Davis) wrote:
> 
> Issue #6724 has been reported by zenspider (Ryan Davis).
> 
> ----------------------------------------
> Bug #6724: waaaaaaant! (
> https://bugs.ruby-lang.org/issues/6724
> 
> Author: zenspider (Ryan Davis)
> Status: Open
> Priority: Normal
> Assignee: ko1 (Koichi Sasada)
> Category: 
> Target version: 
> ruby -v: 2.x
> 
> 
> GIMME GIMME GIMME! waaaaaant... We don't _need_ a verifier. User responsibility... etc etc.
> 
> 
> Can I commit this??? PLEEEEEEASE???
> 
> Index: iseq.c
> ===================================================================
> --- iseq.c	(revision 36369)
> +++ iseq.c	(working copy)
> @@ -1585,9 +1585,7 @@
>      rb_define_method(rb_cISeq, "marshal_load", iseq_marshal_load, 1);
>  #endif
>  
> -    /* disable this feature because there is no verifier. */
> -    /* rb_define_singleton_method(rb_cISeq, "load", iseq_s_load, -1); */
> -    (void)iseq_s_load;
> +    rb_define_singleton_method(rb_cISeq, "load", iseq_s_load, -1);
>  
>      rb_define_singleton_method(rb_cISeq, "compile", iseq_s_compile, -1);
>      rb_define_singleton_method(rb_cISeq, "new", iseq_s_compile, -1);

    require 'dl'
    require 'fiddle'
    require 'minitest/autorun'
    
    class RubyVM
      class InstructionSequence
        address = DL::Handle::DEFAULT['rb_iseq_load']
        func = Fiddle::Function.new(address, [DL::TYPE_VOIDP] * 3, DL::TYPE_VOIDP)
    
        define_singleton_method(:load) do |data, parent = nil, opt = nil|
          func.call(DL.dlwrap(data), parent, opt).to_value
        end
      end
    end
    
    class TestISeq < MiniTest::Unit::TestCase
      def test_load
        ins   = RubyVM::InstructionSequence.new '5 + 10'
        other = RubyVM::InstructionSequence.load ins.to_a
        assert_equal ins.eval, other.eval
      end
    end

<3<3<3<3

-- 
Aaron Patterson
http://tenderlovemaking.com/