[ruby-core:46831] [ruby-trunk - Bug #6804][Closed] test_generate_bin_bindir_with_user_install_warning(TestGemInstaller) fails on windows.

Issue #6804 has been updated by luislavena (Luis Lavena).

Category set to test
Status changed from Open to Closed

Thank you Oleg,

This issue has already been fixed in upstream RubyGems and will be part of release 1.8.25 (not yet released)


----------------------------------------
Bug #6804: test_generate_bin_bindir_with_user_install_warning(TestGemInstaller) fails on windows.
https://bugs.ruby-lang.org/issues/6804#change-28508

Author: os97673 (Oleg Sukhodolsky)
Status: Closed
Priority: Normal
Assignee: luislavena (Luis Lavena)
Category: test
Target version: 2.0.0
ruby -v: ruby 2.0.0dev (2012-07-27) [i386-mingw32]


The test fails on Windows with the following error:
--- expected
+++ actual
@@ -1 +1,3 @@
-""
+"WARNING:  You don't have C:\\Windows in your PATH,
+\t  gem executables will not run.
+"

The problem is incorrect test in Gem::Installer.check_that_user_bin_dir_is_in_path()
It splits PATH by File::PATH_SEPARATOR and checks if the bin dir is included in this array.
But file system is case-insensitive on Windows (and may be case-insensitive on OS X too),
so it is incorrect way to compare these paths as string.
So, I suggest to compare them using File.identical? which should work correctly on any file system.



-- 
http://bugs.ruby-lang.org/