[ruby-core:29050] Re: [Bug #2993] Module#instance_methods' flag seems to be ignored in singleton classes

Hi,

At Mon, 22 Mar 2010 16:42:12 +0900,
Xavier Noria wrote in [ruby-core:28858]:
> Oh sure, is a reference to a single git commit OK?
> 
>     http://github.com/fxn/ruby/commit/6c8eb482a7f89560ce288c3498554cd32a72e762
> 
> If you prefer some other way to submit the patch please just tell me :).

It seems fine for me.

> because AFAICT ordinary and eigenclasses super-chains cannot
> intersect. I don't see a reason why the foor loop should have
> that line at all, and it seems to be the reason
> instance_methods works as reported in this ticket for
> singleton classes. Is that fix correct?

Sounds reasonable.

> How do you run the entire test suite in test/ruby?

make test-ruby

> BTW I followed the instructions here
> http://wiki.github.com/shyouhei/ruby/noncommitterhowto,
> coming in turn from
> http://www.ruby-lang.org/en/community/ruby-core/#git-ruby, in
> case those need to be updated.

The page says:
  Then send me a pull request. I cannot promise (that depends on
  your branch’s content,) but I may perhaps merge your branch to
  mine.

"mine" means his repository here.  In that case, he might have
to post it here and review it again.

-- 
Nobu Nakada