From: Orgad Shaneh <redmine@...>
Date: 2010-03-17T02:27:47+09:00
Subject: [ruby-core:28692] [Bug #2974] WEBrick error in httpstatus

Bug #2974: WEBrick error in httpstatus
http://redmine.ruby-lang.org/issues/show/2974

Author: Orgad Shaneh
Status: Open, Priority: High
ruby -v: ruby 1.8.7 (2010-01-10 patchlevel 249) [i486-linux]

HTTPStatus has some Status classes, which derive from StandardError < Exception.

In Status::initialize, message (which should return a string) is defined to self.class (which is not a string). When the exception is raised, trying to read its message and manipulate it as a string fails.

This issue causes redmine to behave strange when it raises HttpNotModified exception (http 304). It crashes on HTMLUtils escape, and thus return http 500 internal error, leaving the browser without the requested file (which is .js or .css).

I'm attaching a patch I wrote for that. I don't have any experience with ruby, so I just did what felt right. Feel free to modify it as needed :)


----------------------------------------
http://redmine.ruby-lang.org