From: Eric Wong <normalperson@...>
Date: 2017-10-24T23:39:00+00:00
Subject: [ruby-core:83550] Re: [Ruby trunk Feature#13996] [PATCH] file.c: apply2files releases GVL

nobu@ruby-lang.org wrote:
> As `ALLOCV` uses `imemo_alloc` (`NODE_ALLOCA` till 2.4), the contents are marked.

Ah, thanks.  Good to know.

> ```
>     size_t size = sizeof(const char *) + sizeof(VALUE);
>     const long len = (long)(sizeof(struct apply_arg) + (size * argc) - size);
> ```
> 
> I'm afraid that `struct apply_arg` and `fn` in it may not be guaranteed as never-padded.
> Isn't it better to make it a separate struct, and calculate `len` using `offsetof`?

Right, both should be addressed in r60408.  I'm not sure which
platform the padding can affect.  Maybe it cause [Bug #14049]?

Unsubscribe: <mailto:ruby-core-request@ruby-lang.org?subject=unsubscribe>
<http://lists.ruby-lang.org/cgi-bin/mailman/options/ruby-core>